From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. Date: Mon, 17 Jul 2023 17:43:26 +0000 Message-ID: References: <838rbhcxg0.fsf@gnu.org> <83v8ei7c9p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26626"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , 64642@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 19:44:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLSGs-0006kY-Mk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 19:44:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLSGa-0008GC-TN; Mon, 17 Jul 2023 13:44:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLSGS-0008F3-1W for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 13:44:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLSGR-0002Yx-C4 for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 13:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLSGP-0003oP-Ta for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 13:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2023 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64642 X-GNU-PR-Package: emacs Original-Received: via spool by 64642-submit@debbugs.gnu.org id=B64642.168961581714580 (code B ref 64642); Mon, 17 Jul 2023 17:44:01 +0000 Original-Received: (at 64642) by debbugs.gnu.org; 17 Jul 2023 17:43:37 +0000 Original-Received: from localhost ([127.0.0.1]:50859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLSG0-0003n6-Oc for submit@debbugs.gnu.org; Mon, 17 Jul 2023 13:43:36 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:19711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLSFx-0003mi-J2 for 64642@debbugs.gnu.org; Mon, 17 Jul 2023 13:43:35 -0400 Original-Received: (qmail 39756 invoked by uid 3782); 17 Jul 2023 19:43:27 +0200 Original-Received: from acm.muc.de (p4fe15519.dip0.t-ipconnect.de [79.225.85.25]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 17 Jul 2023 19:43:27 +0200 Original-Received: (qmail 3268 invoked by uid 1000); 17 Jul 2023 17:43:26 -0000 Content-Disposition: inline In-Reply-To: <83v8ei7c9p.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265404 Archived-At: Hello, Eli. On Mon, Jul 17, 2023 at 19:06:58 +0300, Eli Zaretskii wrote: > > From: Andrea Corallo > > Cc: Eli Zaretskii , 64642@debbugs.gnu.org > > Date: Mon, 17 Jul 2023 09:42:31 -0400 > > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is > > >> so simple that will surprise me. > > > Here is a fix. Its simplicity probably doesn't surprise you (Eli), but > > > the change is entirely within one function, and a lot of the patch is > > > just whitespace changes. > > > There are no problems running make bootstrap or make check with patch in > > > place. It also solves the bug; unless there are good reasons dynamically > > > bound functions weren't handled. Andrea? > > Hi Alan, > > the fix LGTM thanks for the patch, I think we only need to add a test as > > well to exercise this code, something like the "free-fun" test in > > comp-tests.el. > Alan, when the patch is ready, please install on master. I'll do that, "ready" meaning when I've written that test suggested by Andrea. Thanks! > Thanks. -- Alan Mackenzie (Nuremberg, Germany).