From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brendan O'Dea Newsgroups: gmane.emacs.bugs Subject: bug#56241: [PATCH] icalendar doesn't correctly process arbitrary diary sexp entries Date: Tue, 4 Jul 2023 20:29:03 +1000 Message-ID: References: <21bff87f-b8dc-c7bc-41ab-97c7077a0535@airmail.cc> <87edza8rbu.fsf@gnus.org> <87mtdxt4mr.fsf@gnus.org> <8735eq5qee.fsf@panama> <87o7sxpgfm.fsf@panama> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="diW++iXRrEWZhq/O" Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40702"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 56241@debbugs.gnu.org, Stefan Kangas , hokomo To: Ulf Jasper Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 04 12:30:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGdIg-000AOq-9F for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jul 2023 12:30:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGdIN-0001Fg-Bj; Tue, 04 Jul 2023 06:30:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGdIK-0001FI-5y for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 06:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGdIJ-0003Lv-T9 for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 06:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGdIJ-0004iC-3J for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 06:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brendan O'Dea Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2023 10:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56241 X-GNU-PR-Package: emacs Original-Received: via spool by 56241-submit@debbugs.gnu.org id=B56241.168846658418063 (code B ref 56241); Tue, 04 Jul 2023 10:30:03 +0000 Original-Received: (at 56241) by debbugs.gnu.org; 4 Jul 2023 10:29:44 +0000 Original-Received: from localhost ([127.0.0.1]:35046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGdHz-0004hH-Lw for submit@debbugs.gnu.org; Tue, 04 Jul 2023 06:29:43 -0400 Original-Received: from mail-pf1-f174.google.com ([209.85.210.174]:51707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGdHu-0004h0-FE for 56241@debbugs.gnu.org; Tue, 04 Jul 2023 06:29:41 -0400 Original-Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-666e97fcc60so3131686b3a.3 for <56241@debbugs.gnu.org>; Tue, 04 Jul 2023 03:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c47.org; s=google; t=1688466572; x=1691058572; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=/nT9hWM/9Gujm+8J3bShg+vCVMzX5X9kSXTQq5+0h8E=; b=OVUckbzssEB1W2I4mdnvRBBF1J1LsNNjkvRxcl81XdWEQty7OPuQtPkSYQWiTio/gF QoxnYFmEW/atzvVAVPyMhWPp121UMlYYWvtzFnicheiM3UpuW6ZYLpNijVdRDJGjFIDF ID0SBQQoTcbCJxNYiFBMlasMuQGL1vWdlgprsUlvJUOrMM58Q2MEqupDwGMM5dxUf7C6 H4M4U1xajvh9fCk2OdX/f/lSxUON/2reEXt5/UwzLJfosHLVB2fHRR8oJtWIAZR49NRP 70gKgPFgWEdpewbdOfCTaMt2KUgiWApFAafE9cvxiCqP32Jq3JiM3w7qrFPntCu0Cyi+ 6EpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688466572; x=1691058572; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/nT9hWM/9Gujm+8J3bShg+vCVMzX5X9kSXTQq5+0h8E=; b=WUq4PdS370+NLIJCkUWgBs37zOgqt339BSybfbyqbQ0GuL5RUtS//aZtrNLSBD4FhB 1suQY1imE6uF0lid+v7I8J18hhZyqv3BwhdkVQELqwSlE5EyVu9KDIIX7snvf/fC7ZZl GukaMOAw+oBeRo+4N7yVPDr32IATtPgUzXw5hnI42/lcxncraO1gxzBtdD0nSOSGwX2J P8zqiHlhLxdRqRjX2wSvj7uC96pGqokUKjEhO/vlQTisWQCPybMkGtwcBxt9jYsqGn8C VBu7A1cPx5/ZqcjUqPxGuYuFlEaXABUeqYDmOihIGv9tvnkiiGs4f6HNcZmRIdOcRxCU tQpg== X-Gm-Message-State: ABy/qLZk+QNGMwB5QVNNie/GpJgB3cqg+0321AGvwl6xMAY232GriJ4w 8W+rMGwNHxlNHTmtGM3onm9ZoA== X-Google-Smtp-Source: APBJJlH0dsbvNa71UpBXywAyLrS3aqNy3pYV8UVpdaG1vCiDdxlV0xddCyNg3W4U9glRJdPikveooQ== X-Received: by 2002:a05:6a00:23d4:b0:682:40e2:66c1 with SMTP id g20-20020a056a0023d400b0068240e266c1mr9626136pfc.21.1688466572101; Tue, 04 Jul 2023 03:29:32 -0700 (PDT) Original-Received: from c47.org ([2001:8003:3195:5e01:3a60:77ff:feb4:330c]) by smtp.gmail.com with ESMTPSA id x16-20020a056a00271000b0067459e92801sm13987881pfv.64.2023.07.04.03.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 03:29:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87o7sxpgfm.fsf@panama> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264570 Archived-At: --diW++iXRrEWZhq/O Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Nov 23, 2022 at 09:24:45PM +0100, Ulf Jasper wrote: >I added a test to icalendar-tests.el that verifies that patch >0001-Fix-detecting-dotted-pairs.patch works as expected. Note that this test is failing on both the current 'master' and 'emacs-29' branch (excerpt, full log attached): "Error in line 0 -- (error Could not parse date): `%%(icalendar-tests--diary-float 7 0 1) First Sunday in July 2'\n" FAILED 25/42 icalendar-export-bug-56241-dotted-pair (0.003671 sec) at lisp/calendar/icalendar-tests.el:1000 >From what I can tell, the problem is that while these calls look like they should be identical: (diary-float 7 0 1) (icalendar-tests--diary-float 7 0 1) ;; calls diary-float in practice, they are handled by different code paths: icalendar--convert-float-to-ical icalendar--convert-sexp-to-ical resp. The key difference being that the first one sets 'date' and 'entry' with calendar-dlet when calling diary-float*, and the latter does not. diary-float is documented as requiring those to be set.† I'm not sure of the fix here: if the expectation is that some arbitrary sexp should be able to indirectly call some of the diary-*‡ functions, then it may be that icalendar--convert-sexp-to-ical may need to similarly set those values. Alternately, if that is not supported, then maybe disable/remove the test. --bod * https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/calendar/icalendar.el?id=b42cd524b46a4f29ef13e9d03be9d3df917f9aa3#n1787 † https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/calendar/diary-lib.el?id=b42cd524b46a4f29ef13e9d03be9d3df917f9aa3#n1891 ‡ diary-date, diary-block, diary-float, diary-anniversary, diary-cyclic, and diary-offset (there may be others, those were the ones with an explicit comment) --diW++iXRrEWZhq/O Content-Type: application/gzip Content-Disposition: attachment; filename="icalendar-tests.log.gz" Content-Transfer-Encoding: base64 H4sICADuo2QCA2ljYWxlbmRhci10ZXN0cy5sb2cA7Vxdb9s2FH2OfwWRYoi8hQ71bRnYw9Cm wIYOGJo87qGMRCdCZcqjpHz01++SkhxblNxkQ1EUuHkwKFr33EPykLyXDvixkTKXtyTwSC2q uiKOxzyfspiygLjJKoxW/vIXlzF2TipRiLQuFfnkyLImDpScmt+SVSOrmt8UYt49S17n9yIt N9v5fH42nxFCtryqRAYF9wJckTzlhZAZV5SmpbwXqqY3RZl+pnVJ9XfEYQvwyZIleE0PEbwp hPQpLfJ0CBEyG8KfgihVlkuungYgrhfaIMEUSCUet4cArueNsAinAF7QCdGk7RdarteVqHvq bmJbx1PWD0J8LoatZ9EI+eUUxJPgyoYIYhsisSCU4LWgTZ71ZrFvmblsaJZxLV0FMjZeq1JX 9M2PPRvBHUOo843Q9lmux38Pgvkddyf2GCOXl9dQdNnSlK+uD6EtcWYwDzLRs9JOema+azPz j5g3CqZVKXe6tnvUtSRpGtO3DED2/LMksAEsSa5zVbWyyPgTKMsM746CPStcS5jrUm14bcRA xb2Qz8Ic8W8JM99sSxBVB1LxzbbYNSAYcW/JcstVJWjVbDZ6WLnMqAKx9BxYB3F1/Y4yb8XY u6trynwonP/pL8IFuzAP5tllbUXQVkzYeAv30MZUHNiEK7+10QV4Z+HqV9jO5uD5oHXJeOvu 9bB+KeVOWpG9YnjDadPPVw4bABQqe9VjYafQv5QAR3qbyN925ovFYqI6Ax6zj4Jn1vtjlebt ty0Vy2Ci/piN+Q75Il/ki3yR7/fhu7/tDGMtHaS3+1QYhCOBpTeMoCCY1hEAL7jaVMbQTUJm x06eP2H4vL+1+1oM0bhtHYxbm6yk9cqWcRctXOsIwn61uaVh5AUuzcq6FhlszrkiNzz9XCue ihW4q/JbyQvHxOmAQdc8L8C74zjVXdkUUGrj2F/J6Slxnj2Y1IzSW1FT3bvaXpu+yk6pUtEu TIZwCmCcfE2cRj7kEBRtVVlDcgdAov6H3POiETRyPeLw7bZ4ImsJT4xwdVtBwZ3PuxfXGqbQ yYaO0CBarVKVb3WYCq8F8xe72ME4z/Vnogv8IGyEShP8Un4DXQ19G7m+JjFw3cH8DDgd4zdn Xc/Ayz174kDsk+UGL+WVgP5UvXszQhomLcqqUaDUGizbnKBFmr/YBcBs+DZ1/ifWc99YkjOZ ppDNRrS5AaQtTxXxo0j3jfYNgE7BNzcZJ8NGybz4L7id/KhqZKvhXNZCaVW/qYyw21rxKNLG mOZyXZKVriTdG7rcwfQozt5X+vwAspQXza89GFC3EkM86GdeV2S1O7qAJaolUz0X6WbApnJe c8BB3qwdXcyLIQy94XV69yqw+TiGSVzEY16/FEzDwKxxnGNg5OxraAADxDbaoMiloK7jnNIP p+R0tYAPWsAHOOiLRV5tL/phu9hbhgYwjm6l1CldASnHlhaQFxbO69bV3RTW6ypIe7CmmkrS r4/tE9lfJmcnJy9bKDsa5GDemnHSfyu9+MxG0DuPp5cajuSS6IYTRijVXHXdW7Ny6wEwWRzR 5wPzFfn00082sdb5uih5TWJAcefkvc7MyVUDrz1p/D8aWKe9s7/l6Y6bWUvNRF9BIwouzWTu 2XKlYFbrnD7L12uhIDWHkZC39Z124PptJ52cfJ9GdK7b84dNXm1a5daEdZ3//rffP1y+g507 nNi5R2VjIgA/itv4gQDepGg16YUoVvrw8yBUiL7mUIIpONSraBuxeMtgaR9WePE40KYp6tz0 tGGbsCiybZfjtv0BZhuyhEt/xDQ5bkplSZ/PieLQsw8QfTYO0R0f3ujzs120xexoy3fH7duz w26Qwv6ACsN15DuRXvjDbKE7L9RzEWZikrRaCmI3Qi0h3+Na8qe15PteHHda8v0EtYR8j2sp mNZSFMN+3kppGeGyhHyRL/J9xdISji8th78PL5MElxbk+xUpReNSMgnothD0vv+mTWNZCHsW qgr5Il/ki3yRL/JFvsgX+SJf5PvtspR4PEuRpaRKpI0y/HV+4ieuh/kJ8kW+yBf5Il/ki3yR L/JFvsgX+SJf5It8kS/yRb7IF/kiX+SLfJEv8kW+yPcH/n10Of77qFJNf9NC4oc/6H8D77cz GW/nQ17f0cMbkNw4wauLkO9xPQXsiJ52d9AFnu+hlJAv8kW+yBf5Il/ki3yRL/JFvt8uNRne j6MEL+hDqYo2K4ld37Ov+A2Gl6H09y5NXUEdsO567dlHLndXwJ+De6JE1RR1RXhFxONWpLXI zolLGtk/Hbsoni2CZLlk3QXVswOzDni1f4XTy+5ums3+BRSgNretXgAA --diW++iXRrEWZhq/O--