From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Date: Wed, 28 Jun 2023 20:53:26 +0100 Message-ID: References: <335C856F-41F7-48B8-AF42-B2406065C7A9@gmail.com> <047EC69F-EAC7-458F-A288-13DDC77DE187@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14007"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 63187@debbugs.gnu.org, Eli Zaretskii , Aaron Jensen To: Kai Ma Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 28 21:54:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEbFg-0003OU-Ny for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Jun 2023 21:54:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEbF6-0000Od-5T; Wed, 28 Jun 2023 15:54:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEbEp-00007C-Rs for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 15:54:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEbEo-00062D-Tg for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 15:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEbEo-000695-BC for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 15:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2023 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63187 X-GNU-PR-Package: emacs Original-Received: via spool by 63187-submit@debbugs.gnu.org id=B63187.168798201423584 (code B ref 63187); Wed, 28 Jun 2023 19:54:02 +0000 Original-Received: (at 63187) by debbugs.gnu.org; 28 Jun 2023 19:53:34 +0000 Original-Received: from localhost ([127.0.0.1]:51741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEbEL-00068J-J2 for submit@debbugs.gnu.org; Wed, 28 Jun 2023 15:53:33 -0400 Original-Received: from dane.soverin.net ([185.233.34.149]:47489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEbEJ-000685-0E for 63187@debbugs.gnu.org; Wed, 28 Jun 2023 15:53:31 -0400 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4QrshP4jSYzySl; Wed, 28 Jun 2023 19:53:25 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4QrshN6QwRzGL; Wed, 28 Jun 2023 19:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1687982005; bh=jJZveH+bF3jMwztSlrCqQFdQdfRPWudaOqrRlXmZVHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cp0C9p1DYZQ7D6XJpTECPnq5dGkYgGTsxognvm78enGU1PksRLYKFYgNLfaD+IYF+ 0GOhyGmeqeLb2Qzgk5SSNx3TV+bWxDoFComLOBBDA2SnyWeyyB6mW0l3KA/DkjdkdA I+gJbkGy6TyMP7rJ/Nr3hwidda5LLrqLKFGk6Ib8IyssyKMeBDEwe6o9WuKNEsl5QT FfZfdwsqtav9xZpT49Xkz9hdd1c6jykHhiAQ6cxgKDQasz0L63E0utfhTN43ec8Mtv nfrO9SdD2vq8IiH45C3V6SxYDCMzrwzHhUveKbosGRUNpDaNts5qVolTSOVzcYCIH5 4sZ0ZTB3ziPOQ== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95) (envelope-from ) id 1qEbEE-000bFH-FS; Wed, 28 Jun 2023 20:53:26 +0100 X-Soverin-Authenticated: true Mail-Followup-To: Alan Third , Kai Ma , Aaron Jensen , 63187@debbugs.gnu.org, Eli Zaretskii , Po Lu Content-Disposition: inline In-Reply-To: <047EC69F-EAC7-458F-A288-13DDC77DE187@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264237 Archived-At: On Mon, Jun 26, 2023 at 03:27:41PM +0800, Kai Ma wrote: > > > > On Jun 25, 2023, at 20:46, Alan Third wrote: > > > >>> > >>> modified src/nsterm.m @@ -10622,7 +10622,7 @@ - (void) display > >>> { > >>> NSTRACE_WHEN (NSTRACE_GROUP_FOCUS, "[EmacsLayer display]"); > >>> > >>> - if (context) > >>> + if (context && context != [NSGraphicsContext currentContext]) > >>> { > >>> [self releaseContext]; > >>> > >>> > >>> ... > >>> > >>> Actually... > >>> > >>> That change should probably be made anyway. If the NS run loop kicks > >>> in between an ns_focus call and an ns_unfocus call, it could call > >>> display and our display function will happily destroy the existing > >>> context without creating a new one, so any *subsequent* drawing > >>> operations, up until ns_unfocus, will be lost. > >> > >> OK, I'm adding this to my current build. > >> > >> Is this in line with the type of issue I'm seeing where scrolling > >> works but the ghosting either replicates (or scrolls with it?) In > >> other words, what would you expect to see in this scenario? Would it > >> just stop painting entirely? > > > > > > Kai, it might be worth trying just that change above, while keeping > > the call to performSelectorInMainThread and see if it fixes anything > > for you. > > Unfortunately, the problem persists (as in the YouTube video) if performSelectorInMainThread is present. OK. Thanks for trying it. -- Alan Third