From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#64069: 30.0.50; Mistyped shy group regexps Date: Thu, 15 Jun 2023 20:58:38 +0000 Message-ID: References: <87v8fq570k.fsf@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22132"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Paul Eggert , 64069@debbugs.gnu.org To: Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 15 22:59:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9u3x-0005ZL-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jun 2023 22:59:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9u3f-0000hr-8g; Thu, 15 Jun 2023 16:59:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9u3a-0000hc-Kd for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 16:59:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9u3a-0003l9-CH for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 16:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9u3a-0002Va-8b for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 16:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jun 2023 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64069 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64069-submit@debbugs.gnu.org id=B64069.16868627289620 (code B ref 64069); Thu, 15 Jun 2023 20:59:02 +0000 Original-Received: (at 64069) by debbugs.gnu.org; 15 Jun 2023 20:58:48 +0000 Original-Received: from localhost ([127.0.0.1]:48067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9u3M-0002V6-9J for submit@debbugs.gnu.org; Thu, 15 Jun 2023 16:58:48 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:59113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9u3K-0002Ur-BH for 64069@debbugs.gnu.org; Thu, 15 Jun 2023 16:58:47 -0400 Original-Received: (qmail 29046 invoked by uid 3782); 15 Jun 2023 22:58:39 +0200 Original-Received: from acm.muc.de (pd953a62e.dip0.t-ipconnect.de [217.83.166.46]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 15 Jun 2023 22:58:39 +0200 Original-Received: (qmail 6993 invoked by uid 1000); 15 Jun 2023 20:58:38 -0000 Content-Disposition: inline In-Reply-To: <87v8fq570k.fsf@epfl.ch> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263437 Archived-At: Hello, Basil. On Wed, Jun 14, 2023 at 17:43:39 +0100, Basil Contovounesios wrote: > Severity: minor > Tags: patch > Further to https://bugs.gnu.org/64019#14, I attach a patch which tweaks > four redundant or seemingly mistyped instances of \(:?...\), i.e. a > numbered group starting with an optional colon in place of the likelier > shy group. > CCing: > - Alan to review the change to c-or-c++-mode--regexp Yes, that looks like a bug, just as you've surmised. There are also three other occurrences of \(:? in CC Mode, namely in cc-langs.el. I will fix all of these in master. [ .... ] > diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el > index 11a1d3fe6c2..5cf9b7e17f8 100644 > --- a/lisp/progmodes/cc-mode.el > +++ b/lisp/progmodes/cc-mode.el > @@ -2859,7 +2859,7 @@ c-or-c++-mode--regexp > "\\|" id "::" > "\\|" id ws-maybe "=\\)" > "\\|" "\\(?:inline" ws "\\)?namespace" > - "\\(:?" ws "\\(?:" id "::\\)*" id "\\)?" ws-maybe "{" > + "\\(?:" ws "\\(?:" id "::\\)*" id "\\)?" ws-maybe "{" > "\\|" "class" ws id > "\\(?:" ws "final" "\\)?" ws-maybe "[:{;\n]" > "\\|" "struct" ws id "\\(?:" ws "final" ws-maybe "[:{\n]" [ .... ] -- Alan Mackenzie (Nuremberg, Germany).