From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Date: Fri, 9 Jun 2023 19:27:41 +0100 Message-ID: References: <50104E0C-A861-4762-8081-55F2CF2390AD@gmail.com> <76A3A6C3-CD32-4731-927C-349471F21801@gmail.com> <2A505E20-55E2-4788-A21C-B94068299E50@gmail.com> <29949E40-D5D5-4DE1-BD81-93D1BA3D4F51@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14256"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 63187@debbugs.gnu.org, Eli Zaretskii , Aaron Jensen To: Kai Ma Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 09 20:28:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7gqS-0001al-90 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Jun 2023 20:28:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7gqD-0004qP-7R; Fri, 09 Jun 2023 14:28:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7gqA-0004pq-NF for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 14:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7gqA-00046F-EJ for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 14:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7gq9-0004HB-Ux for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 14:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jun 2023 18:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63187 X-GNU-PR-Package: emacs Original-Received: via spool by 63187-submit@debbugs.gnu.org id=B63187.168633527116421 (code B ref 63187); Fri, 09 Jun 2023 18:28:01 +0000 Original-Received: (at 63187) by debbugs.gnu.org; 9 Jun 2023 18:27:51 +0000 Original-Received: from localhost ([127.0.0.1]:60313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7gpz-0004Gn-E8 for submit@debbugs.gnu.org; Fri, 09 Jun 2023 14:27:51 -0400 Original-Received: from dane.soverin.net ([185.233.34.148]:43121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7gpx-0004GZ-3R for 63187@debbugs.gnu.org; Fri, 09 Jun 2023 14:27:50 -0400 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4Qd8hH08vQz2xQY; Fri, 9 Jun 2023 18:27:43 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by soverin.net (Postfix) with ESMTPSA id 4Qd8hG3gy1zBX; Fri, 9 Jun 2023 18:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1686335262; bh=qjB1tTbhPwZqSAVss5QOfgYSvWmafdeilT/B15s6Nn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KjBDS+jWcBw+pTBK/xQVmpxpwsRCzyi60vtbWtJAxgyvdFVMfrDihBiOvI12dqKH4 Tq/HqixUtC2Gw8MTkAduCVe9+GXfjBIsFBgTL3vXsLkv82PGCZ1eskjRLi36WTD5Rc tsI6dvlvvh0KXXoiXChFYHsk8UpBqAabPUXaxWfjSuk+IGCrrhzQGlqOMceQ208nCD haCJPQ5yJwJVRmIJdQIo1fJej/uSomokAd7EWluhHSxWcHa2fwbPuZkDoCP3aRLYQ3 3GhaefOM0AyIY/E3b82HdRgnQCkxo/NeWdbhZicJtPm5VsZSjCbVw/6pEilosyClED djr0xA6wT2GWQ== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95) (envelope-from ) id 1q7gpp-000PpY-5Q; Fri, 09 Jun 2023 19:27:41 +0100 X-Soverin-Authenticated: true Mail-Followup-To: Alan Third , Kai Ma , Aaron Jensen , 63187@debbugs.gnu.org, Eli Zaretskii , Po Lu Content-Disposition: inline In-Reply-To: <29949E40-D5D5-4DE1-BD81-93D1BA3D4F51@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266026 On Fri, Jun 09, 2023 at 11:12:47AM +0800, Kai Ma wrote: > > > > On Jun 9, 2023, at 10:47, Aaron Jensen wrote: > > > > On Thu, Jun 8, 2023 at 10:42 PM Kai Ma wrote: > >> > >> Increasing CACHE_MAX_SIZE alone doesn’t seem to help much. > >> (Screencast: https://www.youtube.com/watch?v=9YD9jyP-GKw) > >> > >> Increasing CACHE_MAX_SIZE + Removing performSelectorOnMainThread seems to be better but I can’t be sure. Just observed: > >> > >> (1) M-< at the mid of a buffer, but only the first line of the view is refreshed, and other parts were still there. > >> > >> (2) selecting a region doesn’t always clear the hl-line effect. > > > > What are you doing to make your background translucent? I've never > > seen anything nearly as bad as what you have. I've only seen a glitch > > maybe once since the last patch (and that may have even been something > > else). It makes me wonder if there's something else different/off > > about your setup. > > (set-frame-parameter nil 'alpha 0.95) > > Indeed I haven’t been able to reproduce this bug in emacs -q so far. > I thought I didn’t do anything unconventional, but, well, > polling-period seems to be the culprit. > > I had in my config > (setq polling-period 0.01) > to increase the responsiveness of C-g, and reverting the change to > the default value 2.0 is effective. Well, I have no idea what that actually means in terms of the display. It seems to me that removing the call to performSelectorOnMainThread should be done. That may even fix Aaron's original issue too, given that I don't know why calling setNeedsDisplayInRect twice in a row should help, especially given it's not actually used anywhere else in the display code. (And it should probably be [view setNeedsDisplay:YES] if it's needed there at all.) If tearing becomes a wider problem probably the best option would be to actually wait for a surface to become free before taking it off the cache, but... I dunno. I don't really know how we do that without just having a loop polling continuously. Sleep for a few milliseconds each time round the loop? -- Alan Third