From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#61962: 30.0.50; New trouble with symbols with positions Date: Tue, 7 Mar 2023 15:42:05 +0000 Message-ID: References: <87o7p8v6ak.fsf@web.de> <83ilfga322.fsf@gnu.org> <877cvvqj5v.fsf@web.de> <877cvv0yv7.fsf@web.de> <87a60p4d5q.fsf@web.de> <83356g7lh7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21110"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, mattiase@acm.org, 61962@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 07 16:43:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZZTL-0005KV-If for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Mar 2023 16:43:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZZT5-0005Fj-O3; Tue, 07 Mar 2023 10:43:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZZT1-0005BN-NZ for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 10:43:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZZSw-0006LU-Cb for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 10:43:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZZSw-0007bt-1i for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 10:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2023 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61962 X-GNU-PR-Package: emacs Original-Received: via spool by 61962-submit@debbugs.gnu.org id=B61962.167820373629191 (code B ref 61962); Tue, 07 Mar 2023 15:43:02 +0000 Original-Received: (at 61962) by debbugs.gnu.org; 7 Mar 2023 15:42:16 +0000 Original-Received: from localhost ([127.0.0.1]:46992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZZSC-0007al-4l for submit@debbugs.gnu.org; Tue, 07 Mar 2023 10:42:16 -0500 Original-Received: from mx3.muc.de ([193.149.48.5]:36929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZZSA-0007aU-Gk for 61962@debbugs.gnu.org; Tue, 07 Mar 2023 10:42:15 -0500 Original-Received: (qmail 11799 invoked by uid 3782); 7 Mar 2023 16:42:07 +0100 Original-Received: from acm.muc.de (pd953aca1.dip0.t-ipconnect.de [217.83.172.161]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 07 Mar 2023 16:42:07 +0100 Original-Received: (qmail 26804 invoked by uid 1000); 7 Mar 2023 15:42:05 -0000 Content-Disposition: inline In-Reply-To: <83356g7lh7.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257475 Archived-At: Hello, Eli. On Tue, Mar 07, 2023 at 15:13:40 +0200, Eli Zaretskii wrote: > > Date: Tue, 7 Mar 2023 10:24:41 +0000 > > Cc: Mattias Engdegård , > > Eli Zaretskii , 61962-done@debbugs.gnu.org > > From: Alan Mackenzie > > I've now written safe-copy-tree, and committed it together with the fix > > in bytecomp.el to master. > Next time when you post a patch and ask for comments, please allow > some time for responses, including to those who might be in different > time zones or have less free time on their hands. 13 hours you waited > is definitely not enough. Yes. For some reason I was in a bit of a hurry to close the bug. > Btw, what are these "NEW STOUGH" markers you added to bytecomp.el: > +;;;; NEW STOUGH, 2023-03-05 > + (byte-run-strip-symbol-positions > +;;;; END OF NEW STOUGH > (byte-compile-sexp > (let ((form (read-positioning-symbols (current-buffer)))) > (push form byte-compile-form-stack) > (eval-sexp-add-defvars > form > - start-read-position)))) > + start-read-position))) > +;;;; NEW STOUGH, 2023-03-05 > + ) > +;;;; END OF NEW STOUGH > + ) A change I didn't intend to commit, now tidied up and removed. I've also tidied up the documentation, and now delete the hash table at the end of the function, as you suggested in another post. > Also, how about adding some tests, to make sure we don't regress in > this area in the future? Good idea! I'll see what I can manage. -- Alan Mackenzie (Nuremberg, Germany).