From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image Date: Sat, 28 Dec 2024 12:37:52 +0000 Message-ID: References: <86y10rh26m.fsf@gnu.org> <87plm3ghzw.fsf@yahoo.com> <86frmyhfss.fsf@gnu.org> <87h67eha9b.fsf@yahoo.com> <86plm2fk1l.fsf@gnu.org> <86frmh8kj9.fsf@gnu.org> <87o714pnpq.fsf@yahoo.com> <86a5co6wnv.fsf@gnu.org> <86pllcro1k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 74725-done@debbugs.gnu.org, da_vid@orange.fr To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 28 13:39:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRW6A-0002au-SF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Dec 2024 13:39:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRW5x-00050R-4s; Sat, 28 Dec 2024 07:39:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRW5u-0004zi-MO for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 07:39:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRW5u-0000r1-Ci for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 07:39:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=+YGuVotplkOMMueJeYPTCBBzQocwo0XQIvWl+bk/dlg=; b=j3+5m2On0fMt73zJNehkYHD0sYKvVDnDJSP/qWEYyK6+TD3euaJArdxRfxe7NFSFnLD99hqXvR3CB1YEWrvsMIh+s37A5u1YFDB6CUXbPZ91rTroIUBUvj6CI7v3ejP8Q8Te2UmFHNeKNes1W3s3XqIT9NaKM+VkPWvJ4z1mN5bkd9MY8hFMSgXBLhOuIcUI/rO+lyUJ6c83Ihf6NTfZRPQZCChWBaPmmPASQ4PA6oh2reC302jnlqN+iA0ue4NFQT+WujpVSwsLMkFVok7adQJS4oO827DNenEF/pqpSUyOxQ1rTqtSuu1x2Odzq/AyIyQAJXat/Wcq9jPC0BkncA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRW5u-0002lY-7V for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 07:39:02 -0500 Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2024 12:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74725 X-GNU-PR-Package: emacs Original-Received: via spool by 74725-done@debbugs.gnu.org id=D74725.173538948410544 (code D ref 74725); Sat, 28 Dec 2024 12:39:01 +0000 Original-Received: (at 74725-done) by debbugs.gnu.org; 28 Dec 2024 12:38:04 +0000 Original-Received: from localhost ([127.0.0.1]:49690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRW4y-0002k0-AK for submit@debbugs.gnu.org; Sat, 28 Dec 2024 07:38:04 -0500 Original-Received: from dane.soverin.net ([185.233.34.149]:56187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRW4v-0002jP-CV for 74725-done@debbugs.gnu.org; Sat, 28 Dec 2024 07:38:02 -0500 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4YL22V4jjZzyh4; Sat, 28 Dec 2024 12:37:54 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by soverin.net (Postfix) with ESMTPSA id 4YL22T65KhzFh; Sat, 28 Dec 2024 12:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1735389474; bh=1Ge8zJ47yxfIaLHAmqVnWBiwBQYG5pGknA9xTNP02cQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nnY9LpvdWUM722CkSEXy1nuKKi7++B2NvU++makL/FUgK/0nKiTzk2aWGtCmksrvA HvEUhFCzHn9owFgYlbjpKcEhsW/u/NcbOFylQ6X3LJIU6aT+POdK5Dml5iFJ4MW+6u mKRZtEfRiPEvDyIhqNiuJWLrw7Yl5oACZGFlq2agQAN3sY/k+sSIKb+Xw7gzW8Bdqq fK27Z8E4uaw/DZarSk1juxpZYbq0rIgAm4q4NhLd/MGKZrIEkEQsUIc/SHz/hxVbOx Wcoc7hpFG1qDbklsVIxIqU8VEpeW9Y+rYeQ1Yv/kl/JPdbbVEBlrDpwJY2zoCQbDi+ Fi+AwOTzGq5YA== X-CM-Envelope: MS4xfDkhwHhZkxIZPnvflTfpGkOzEditFJSYX7fIgEiaqCngiEFgHJfdAMAXZqrM42XM0V/TS/F1aF0tUEygvpdAaQVkbOeabw6Vnypj5N15Wlcod5VCQNCN di/98rlPs8wi6uM6LgJP/vQ4f9NVkFv4yr4FVciqD9xXb3kWRj7bn9vD2P96Z1xHcASFNkwLpo2elPdG/Td0E4oYZ+o6VRuoezMJQ+HetIlKLdpcnfgo8d2c oxvbVaOL4Q/RiwwaMFZGZJfqcP3AlVg4KohD/4iKiOGbVbJCrjf6ncuKkyUlO+M9 X-CM-Analysis: v=2.4 cv=e8f8Sbp/ c=1 sm=1 tr=0 ts=676ff122 a=UbsBXRcqaZ6D9kgPt/Dvnw==:617 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=RZcAm9yDv7YA:10 a=hIj89exaAAAA:8 a=CjxXgO3LAAAA:8 a=mDV3o1hIAAAA:8 a=Y9vsEcAVA5bSJFaaRsAA:9 a=CjuIK1q_8ugA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 a=9MSFP0l5Dcwi9NrB_JPx:22 Original-Received: from localhost (faroe.holly.idiocy.org [local]) by faroe.holly.idiocy.org (OpenSMTPD) with ESMTPA id 2f67a744; Sat, 28 Dec 2024 12:37:52 +0000 (UTC) Mail-Followup-To: Alan Third , Eli Zaretskii , luangruo@yahoo.com, 74725-done@debbugs.gnu.org, da_vid@orange.fr Content-Disposition: inline In-Reply-To: <86pllcro1k.fsf@gnu.org> X-Spampanel-Class: ham X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297899 Archived-At: On Sat, Dec 28, 2024 at 02:26:47PM +0200, Eli Zaretskii wrote: > > Date: Fri, 27 Dec 2024 12:11:33 +0000 > > From: Alan Third > > Cc: Po Lu , 74725@debbugs.gnu.org, da_vid@orange.fr > > > > > Alan, could you please prepare a patch (for the master branch) that > > > records the scaling factor in the image cache and rejects a cache hit > > > with a different scaling factor? > > > > Hi Eli, patch attached. > > Thanks, LGTM. > > > I named a new function image_compute_scale because most of the other > > functions in that file start image_, however I wasn't sure if I should > > name it compute_image_scale to mirror compute_image_size. Let me know > > if you think I should change it. > > Static functions can have any names we see fit, so feel free to rename > if you think compute_image_scale would be better. > > Feel free to install on master, when you are satisfied with the code. Done. Thanks. -- Alan Third