From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image Date: Sat, 7 Dec 2024 15:49:47 +0000 Message-ID: References: <2304cad6-884f-4528-a85e-ab9c06b80016@orange.fr> <868qsrim4a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25956"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74725@debbugs.gnu.org, David Ponce To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 16:50:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJx4e-0006az-Rv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 16:50:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJx4H-0006vw-JY; Sat, 07 Dec 2024 10:50:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJx4F-0006vk-9f for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 10:50:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJx4E-0002Xk-U1 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 10:50:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=aHOuFpP09xy7L6BMkGSsF17qR5NfXmTyOXxpo9CAjS8=; b=cZaqrWQX2jZ4iJ35Wik8hCOTBuD2VNpTC2CKr7PdoCksh/bx6ARcz+CiHkCtspumsgpiaJ7jrm+RGKl4Yt0fUTHQJ+/8T1Xi65TH1GYV9kcMLtzK9yfgCLhuYs4pbS3TPrs9cO7aROl+FKYe2DLMoeIisQa52NvZ5jamz0YcyLr7bkmG7gNwxu49l96cqMbIRoPJYboyP0TJI/4BABNQtvkzN78NzbGOKrBICyWJHPu6yNXXmO08Nm4EWQJEgRG4GiOjVbo4Qz5peEqJ0h2AJdDV3zI11dPw8YA/aSWSSH3AVEIPHal4LTC/G2Qes93EOmAXrCr0llXcNxU3otfK7g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJx4E-0004H7-Ha for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 10:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74725 X-GNU-PR-Package: emacs Original-Received: via spool by 74725-submit@debbugs.gnu.org id=B74725.173358659916414 (code B ref 74725); Sat, 07 Dec 2024 15:50:02 +0000 Original-Received: (at 74725) by debbugs.gnu.org; 7 Dec 2024 15:49:59 +0000 Original-Received: from localhost ([127.0.0.1]:48232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJx4B-0004Gf-0I for submit@debbugs.gnu.org; Sat, 07 Dec 2024 10:49:59 -0500 Original-Received: from dane.soverin.net ([185.233.34.25]:41589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJx49-0004GO-9a for 74725@debbugs.gnu.org; Sat, 07 Dec 2024 10:49:58 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4Y5CHd66YGzySw; Sat, 7 Dec 2024 15:49:49 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by soverin.net (Postfix) with ESMTPSA id 4Y5CHd1MhrzF2; Sat, 7 Dec 2024 15:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1733586589; bh=CdkPRAOujNtVLl5LvTp+bqbUNbgOyZKz8sfQxEVPtds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nbQd3V1pXAlDd01XFpZQj12tesBnOeO8iLNPQzkwtkmudBwCvJhElDpCKsURffr9x BSNn8BDtxI+WZ1HEvYdaST/UrpHxUleKwQytJqr9yJ9+r1o8guZe+X9YQWICNhJJtt f7owQFrRn7grNMeQY8lQaxVBXDGKJgmtI2PfRaCukWPB8W4NIZnk6cPSt88pvqte1L tGBSEzLM0FrtWlgFXmDLss6RgtyeMdTzLGmzK43Ud+ZRScfMWzsHRVpjNpG+rlWme6 f8gukedoTLQrY/4F+jGYMKZQUXtmLv2hgHhzPGGI6KMBbK0A9NBoU3x0ucjM41J4Y4 EWXuyZCFA5Nww== Original-Received: from localhost (faroe.holly.idiocy.org [local]) by faroe.holly.idiocy.org (OpenSMTPD) with ESMTPA id 75ce5f7b; Sat, 7 Dec 2024 15:49:47 +0000 (UTC) Mail-Followup-To: Alan Third , Eli Zaretskii , David Ponce , 74725@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <868qsrim4a.fsf@gnu.org> X-Spampanel-Class: ham X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296576 Archived-At: On Sat, Dec 07, 2024 at 04:49:41PM +0200, Eli Zaretskii wrote: > > Date: Sat, 7 Dec 2024 13:13:58 +0100 > > From: David Ponce via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > While working with images, I found what seems an issue to me with > > `create-image' which unconditionally set the :scale image property to > > 'default' when not specified, ignoring the value of the option > > `image-scaling-factor'. > > > > Here is an illustration: > > > > (let ((image-scaling-factor 1.0)) > > (image-size > > (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg"))) > > t)) > > => (63 . 63) > > > > (let ((image-scaling-factor 2.0)) > > (image-size > > (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg"))) > > t)) > > => (63 . 63) > > > > (image-size > > (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg" :scale 1))) > > t) > > => (48 . 48) > > > > (image-size > > (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg" :scale 2))) > > t) > > => (96 . 96) > > > > You can replace `image-size' with `insert-image' and observe the same. > > > > Here is a simple patch which fix the issue for me: > > > > diff --git a/lisp/image.el b/lisp/image.el > > index ce97eeb3ca1..2c1e865c336 100644 > > --- a/lisp/image.el > > +++ b/lisp/image.el > > @@ -536,7 +536,9 @@ create-image > > file-or-data) > > (and (not (plist-get props :scale)) > > ;; Add default scaling. > > - (list :scale 'default)) > > + (list :scale (if (numberp image-scaling-factor) > > + image-scaling-factor > > + 'default))) > > props))) > > ;; Add default smoothing. > > (unless (plist-member props :transform-smoothing) > > AFAIU, this is supposed to be taken care of in image.c. > > Alan, any ideas why this doesn't seem to work? It's because the image spec doesn't change so the image is pulled from the cache each time. Flushing the image between calls to image-size fixes it: (image-flush (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg")))) I'm not sure what the solution is here. My feeling is that image-scaling-factor isn't intended as something you set for each image as you load it, it's a set-and-forget setting, so perhaps we just need to document that in order for it to take effect the image cache needs to be flushed. Alternatively we make the image cache aware of it. Perhaps we can flush the cache automatically when it changes? That might give unexpected results too. -- Alan Third