From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#74476: [PATCH] Explore JPEG loading without quantization Date: Sat, 30 Nov 2024 18:16:39 +0000 Message-ID: References: <871pz39v6p.fsf@ledu-giraud.fr> <86iks581nf.fsf@gnu.org> <87y11093gx.fsf@ledu-giraud.fr> <87h67obpn6.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39457"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 74476@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 30 19:18:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHS36-000A8P-DQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Nov 2024 19:18:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHS2m-0000p5-1l; Sat, 30 Nov 2024 13:18:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHS2d-0000og-IH for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 13:18:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHS2c-0005go-TL for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 13:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=1TaQ8KaotWR5yF96U2TlzPUvGOA8NhA8CUGw1X9Ph8Q=; b=ePcx2BhzUOpBQfY+OyZD5wkLxEQen4twZcICJO2m1pyf7ysa4+7xkDaF3ZV97sz3TOpE+lZGc8j+yv3OgOCx9Wuv0UYcewAz9t9yUI41mnRVGbq0cTN/WEBCwnGoCrTT/c1UW0F7g+mkSaEe0jFNyM63i7tXI32+pBWTm8+7CIxC9CQT/jMPcnSoIbekgns9JL5oVxjXs+OTY0a+NZcuYox42JGzYmJR5EPlDSDr5ftX8NswmPGnG0wHPiED2ZxeWsW94R+8irrsL8Ey2N+04wHONa0lP0k8ehwY6sTvr1+Ad929SEwPQalGjrVPY8lyRcR6f5x5YF+yPsr84bXwEA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHS2c-0000OE-GI for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 13:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2024 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74476 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74476-submit@debbugs.gnu.org id=B74476.17329906401427 (code B ref 74476); Sat, 30 Nov 2024 18:18:02 +0000 Original-Received: (at 74476) by debbugs.gnu.org; 30 Nov 2024 18:17:20 +0000 Original-Received: from localhost ([127.0.0.1]:48958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHS1v-0000Mx-Qo for submit@debbugs.gnu.org; Sat, 30 Nov 2024 13:17:20 -0500 Original-Received: from dane.soverin.net ([185.233.34.35]:45507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHS1u-0000Mc-Bm for 74476@debbugs.gnu.org; Sat, 30 Nov 2024 13:17:18 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4Y0ytJ3z9TzV3K; Sat, 30 Nov 2024 18:16:40 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4Y0ytJ0MxPzV0; Sat, 30 Nov 2024 18:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1732990600; bh=VnbXE4YnEuy3OMQKqTg6Zqjp2sDNkJrF8D80EHo2i7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k16F5CW8TfpgcPTvhMc/U7ypBAEjGss9FqL5JxruoaMuXsL9dcA2h8Nb7C8ofRj19 EoiIrv7FXth23pww95V6aAckjRzGKqhwEkvCJwiUGV5fIrioypZcF9VEyovDwyAO1J 5vgH7rEVZ7JQ1LUygK/lztKvgTJvxLfBzezMFOIwItRnJ7fR6R7+VwrrW3XNKFmJw0 ad6e6jeaYe6AnSnEuYTCLT8sSnxatA2s/MYMCQdb0TRxjBmHpJR8KjN16xzDV/Vfxz rQYHE/PathV/UIPhCuDX1hNmlc8rW6jW237t1MrbKAJkvehkkmB8SGBjo3GsvaCMRo PM4qiZI0zSrtA== Original-Received: from localhost (faroe.holly.idiocy.org [local]) by faroe.holly.idiocy.org (OpenSMTPD) with ESMTPA id b6c5627e; Sat, 30 Nov 2024 18:16:39 +0000 (UTC) Mail-Followup-To: Alan Third , Manuel Giraud , Eli Zaretskii , 74476@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <87h67obpn6.fsf@ledu-giraud.fr> X-Spampanel-Class: ham X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296188 Archived-At: On Sat, Nov 30, 2024 at 06:25:01PM +0100, Manuel Giraud wrote: > Here is a new version with Alan suggestions. > > FTR, the gain is much less interesting. Here is the new timing with > same benchmark (see below): > (4.381739669 1 0.1034133749999997) That's unfortunate, although here I see an improvement of greater than 2x. Probably I could do with finding some larger images as the whole thing completes in under a second even without your patch. I've had a quick dig into lookup_rgb_color and assuming you have a true colour display and there's no gamma calculation going on (I don't know when that happens) it shouldn't be doing a whole lot more. Perhaps it's just the extra over-head of calling a function? -- Alan Third