From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#59790: 30.0.50; ns-use-native-fullscreen is not respected for first use of initial-frame-alist Date: Sun, 24 Nov 2024 11:59:01 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12702"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59790@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 24 13:00:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFBHl-0003AT-1w for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Nov 2024 13:00:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFBHZ-0002IA-HI; Sun, 24 Nov 2024 07:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFBHX-0002Hi-KO for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 07:00:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tFBHX-0002JM-1a for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 07:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=u2rNnhvDy16dymaZWJDxbuIpE/CBd7cWWEohesEYSx0=; b=FBSgD21CHkZ9C9d5r5ALZb1fLsj6n6ESA7R4XQrd+QpUOvKSwuDqTCxPkrrNeoM1xsPLti4WkS0PhBDCrrdkjZZGYM67voeRHzG+iDEHjNVrMhBs2KbQsaM7YSR50QOaE9mFPP4i5sBTG3kzCPlCX5QmyJw1EiU+FSrHWshBlyY9h0sR8zmrHDkz9FfynPRkYZtgBiWAm2GGrNywo0G3VtxbA3PqPQLVRH2exvgrqYb2Swoo1y0DdUYe4QN5hy3p4vWEeVsFPt5fQWOdO0S7EJ2dc4AdlpqGMFFpwQ69cqAMvDGhVKgxH/MqM9xBqylWWc2gdsbY56HDJYYBjtzNgQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tFBHW-0007lV-Qo for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2024 07:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Nov 2024 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59790 X-GNU-PR-Package: emacs Original-Received: via spool by 59790-submit@debbugs.gnu.org id=B59790.173244958329785 (code B ref 59790); Sun, 24 Nov 2024 12:00:02 +0000 Original-Received: (at 59790) by debbugs.gnu.org; 24 Nov 2024 11:59:43 +0000 Original-Received: from localhost ([127.0.0.1]:33113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFBHC-0007kF-Cu for submit@debbugs.gnu.org; Sun, 24 Nov 2024 06:59:42 -0500 Original-Received: from dane.soverin.net ([185.233.34.158]:44351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFBH9-0007jq-Kc for 59790@debbugs.gnu.org; Sun, 24 Nov 2024 06:59:40 -0500 Original-Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4Xx6nL2ntRz10bG; Sun, 24 Nov 2024 11:59:02 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by soverin.net (Postfix) with ESMTPSA id 4Xx6nK5s8TzHS; Sun, 24 Nov 2024 11:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1732449542; bh=sEh6Dr0kANjeBMMDVQU8uPnEAA6Yt/Gk1TDg/31GhKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rdt6KihV+AXF3j2Y1O3AvAUxzP4LEiHXB5ZNvwvIepJG/LjUKM9cxerGuzTMC56wG ktfnWJHkt5sjNr5l6UJ9WDvdjs2uHLd8lEFSv3iChddpqgBrN0c/7bp88+Ql8QDPTR gdMw3IFuH4QnxyR7IUXa92o5MwSXstVI46T815b4DVnqx/z2wl5VLVh7nOeIcPgGKq qSZskmsZ2oRWwL2nd29ZAKkyy4SBm6s8FoNyH8PzRH11opgn1LGwJcOnEh3DRkDhjW 9JImDC01MWRKU0FBdWM3QcpDYBoNJY3c8Scb83tjXB8Ivnk6DkvbJzDbYYoASqQz7r iVgtRl6nZcxgw== Mail-Followup-To: Alan Third , Aaron Jensen , 59790@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-Spampanel-Class: ham X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295904 Archived-At: On Sun, Nov 17, 2024 at 12:00:07AM -0500, Aaron Jensen wrote: > ​The bugged behavior is that `ns-use-native-fullscreen' set to nil is not read > when launching emacs. > > > The attached patch should fix this. The problem is that when the frame is > made, the current value of ns-use-native-fullscreen is copied to a variable > and that's only reset when the frame goes from fullscreen to windowed. I > believe the original intent was to ensure that the mode could not change > while the window was fullscreen already. > > This resets the value of fs_is_native if the frame is not already > fullscreen, which allows it to respect the value at the time of the first > fullscreen. > > Without this, the only way to get the behavior that Sean is expecting is to > set ns-use-native-fullscreen in early-init, which should not be necessary. Pushed to emacs-30 as 03ae07291e85fd353595806c3ce1ad3315c47649. -- Alan Third