* bug#57911: master 60102016e4: Abolish max-specpdl-size (bug#57911) [not found] ` <87pmfrqjvc.fsf@gnus.org> @ 2022-09-27 8:47 ` Alan Mackenzie [not found] ` <YzK4s1X++EmI6CL+@ACM> 1 sibling, 0 replies; 3+ messages in thread From: Alan Mackenzie @ 2022-09-27 8:47 UTC (permalink / raw) To: Lars Ingebrigtsen Cc: 57911, Mattias EngdegÃ¥rd, Michael Albinus, Stefan Monnier, emacs-devel Hello, Lars. On Mon, Sep 19, 2022 at 20:50:15 +0200, Lars Ingebrigtsen wrote: > Thanks, Mattias. > Just a note that this adds a couple of warnings which perhaps Michael > and Alan can have a look at: > In c-get-lang-constant: > progmodes/cc-defs.el:2685:37: Warning: ‘max-specpdl-size’ is an obsolete variable (as of 29.1). > progmodes/cc-defs.el:2685:15: Warning: ‘max-specpdl-size’ is an obsolete variable (as of 29.1). I've now fixed these warnings. > In toplevel form: > net/tramp-gvfs.el:2511:32: Warning: ‘max-specpdl-size’ is an obsolete variable (as of 29.1). > net/tramp-gvfs.el:2511:10: Warning: ‘max-specpdl-size’ is an obsolete variable (as of 29.1). > In tramp-archive-file-name-handler: > net/tramp-archive.el:351:37: Warning: ‘max-specpdl-size’ is an obsolete variable (as of 29.1). > net/tramp-archive.el:351:15: Warning: ‘max-specpdl-size’ is an obsolete variable (as of 29.1). -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <YzK4s1X++EmI6CL+@ACM>]
* bug#57911: master 60102016e4: Abolish max-specpdl-size (bug#57911) [not found] ` <YzK4s1X++EmI6CL+@ACM> @ 2022-09-27 9:01 ` Mattias Engdegård 2022-09-27 10:14 ` Alan Mackenzie 0 siblings, 1 reply; 3+ messages in thread From: Mattias Engdegård @ 2022-09-27 9:01 UTC (permalink / raw) To: Alan Mackenzie Cc: 57911, Lars Ingebrigtsen, Michael Albinus, Stefan Monnier, emacs-devel 27 sep. 2022 kl. 10.47 skrev Alan Mackenzie <acm@muc.de>: > I've now fixed these warnings. Thank you Alan! One detail though: > (let ((-varlist- varlist) msp-binding) Here `-varlist-` aliases `varlist`... > (setq -varlist- (delq 'max-specpdl-size -varlist-))) ... the original macro argument is mutated, which is directly from the source code -- maybe don't do that in a macro? Then we set `-varlist-`, but that's a dead store because... > `(let* ,varlist ,@body))) ... we use `varlist`. ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#57911: master 60102016e4: Abolish max-specpdl-size (bug#57911) 2022-09-27 9:01 ` Mattias Engdegård @ 2022-09-27 10:14 ` Alan Mackenzie 0 siblings, 0 replies; 3+ messages in thread From: Alan Mackenzie @ 2022-09-27 10:14 UTC (permalink / raw) To: Mattias Engdegård Cc: 57911, Lars Ingebrigtsen, Michael Albinus, Stefan Monnier, emacs-devel Hello, Mattias. On Tue, Sep 27, 2022 at 11:01:40 +0200, Mattias Engdegård wrote: > 27 sep. 2022 kl. 10.47 skrev Alan Mackenzie <acm@muc.de>: > > I've now fixed these warnings. > Thank you Alan! One detail though: > > (let ((-varlist- varlist) msp-binding) > Here `-varlist-` aliases `varlist`... > > (setq -varlist- (delq 'max-specpdl-size -varlist-))) > ... the original macro argument is mutated, which is directly from the source code -- maybe don't do that in a macro? > Then we set `-varlist-`, but that's a dead store because... > > `(let* ,varlist ,@body))) > ... we use `varlist`. Thanks for spotting those mistakes. I think I've now fixed them with a second commit. -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-27 10:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <166360889903.6127.6574959318930089210@vcs2.savannah.gnu.org>
[not found] ` <20220919173459.EC224C00872@vcs2.savannah.gnu.org>
[not found] ` <87pmfrqjvc.fsf@gnus.org>
2022-09-27 8:47 ` bug#57911: master 60102016e4: Abolish max-specpdl-size (bug#57911) Alan Mackenzie
[not found] ` <YzK4s1X++EmI6CL+@ACM>
2022-09-27 9:01 ` Mattias Engdegård
2022-09-27 10:14 ` Alan Mackenzie
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).