From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#57911: master 60102016e4: Abolish max-specpdl-size (bug#57911) Date: Tue, 27 Sep 2022 10:14:55 +0000 Message-ID: References: <166360889903.6127.6574959318930089210@vcs2.savannah.gnu.org> <20220919173459.EC224C00872@vcs2.savannah.gnu.org> <87pmfrqjvc.fsf@gnus.org> <6C25AF59-A9DC-4391-9799-24839E79033D@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30906"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57911@debbugs.gnu.org, Lars Ingebrigtsen , Michael Albinus , Stefan Monnier , emacs-devel@gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 12:18:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1od7fF-0007ot-TU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 12:18:09 +0200 Original-Received: from localhost ([::1]:47550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1od7fE-0000Cr-QB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 06:18:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od7dC-0006zv-Tp for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 06:16:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1od7dC-00038n-Lp for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 06:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1od7dC-0005Qw-GM for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 06:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 10:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57911 X-GNU-PR-Package: emacs Original-Received: via spool by 57911-submit@debbugs.gnu.org id=B57911.166427371020802 (code B ref 57911); Tue, 27 Sep 2022 10:16:02 +0000 Original-Received: (at 57911) by debbugs.gnu.org; 27 Sep 2022 10:15:10 +0000 Original-Received: from localhost ([127.0.0.1]:52908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od7cM-0005PR-8P for submit@debbugs.gnu.org; Tue, 27 Sep 2022 06:15:10 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]:28505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od7cG-0005Oa-Eb for 57911@debbugs.gnu.org; Tue, 27 Sep 2022 06:15:08 -0400 Original-Received: (qmail 11361 invoked by uid 3782); 27 Sep 2022 12:14:57 +0200 Original-Received: from acm.muc.de (p4fe1575c.dip0.t-ipconnect.de [79.225.87.92]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 27 Sep 2022 12:14:56 +0200 Original-Received: (qmail 11986 invoked by uid 1000); 27 Sep 2022 10:14:55 -0000 Content-Disposition: inline In-Reply-To: <6C25AF59-A9DC-4391-9799-24839E79033D@acm.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243708 gmane.emacs.devel:296336 Archived-At: Hello, Mattias. On Tue, Sep 27, 2022 at 11:01:40 +0200, Mattias Engdegård wrote: > 27 sep. 2022 kl. 10.47 skrev Alan Mackenzie : > > I've now fixed these warnings. > Thank you Alan! One detail though: > > (let ((-varlist- varlist) msp-binding) > Here `-varlist-` aliases `varlist`... > > (setq -varlist- (delq 'max-specpdl-size -varlist-))) > ... the original macro argument is mutated, which is directly from the source code -- maybe don't do that in a macro? > Then we set `-varlist-`, but that's a dead store because... > > `(let* ,varlist ,@body))) > ... we use `varlist`. Thanks for spotting those mistakes. I think I've now fixed them with a second commit. -- Alan Mackenzie (Nuremberg, Germany).