From: Alan Mackenzie <acm@muc.de>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 57911@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
Michael Albinus <michael.albinus@gmx.de>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: bug#57911: master 60102016e4: Abolish max-specpdl-size (bug#57911)
Date: Tue, 27 Sep 2022 10:14:55 +0000 [thread overview]
Message-ID: <YzLNH+kZl5JcmUbR@ACM> (raw)
In-Reply-To: <6C25AF59-A9DC-4391-9799-24839E79033D@acm.org>
Hello, Mattias.
On Tue, Sep 27, 2022 at 11:01:40 +0200, Mattias Engdegård wrote:
> 27 sep. 2022 kl. 10.47 skrev Alan Mackenzie <acm@muc.de>:
> > I've now fixed these warnings.
> Thank you Alan! One detail though:
> > (let ((-varlist- varlist) msp-binding)
> Here `-varlist-` aliases `varlist`...
> > (setq -varlist- (delq 'max-specpdl-size -varlist-)))
> ... the original macro argument is mutated, which is directly from the source code -- maybe don't do that in a macro?
> Then we set `-varlist-`, but that's a dead store because...
> > `(let* ,varlist ,@body)))
> ... we use `varlist`.
Thanks for spotting those mistakes. I think I've now fixed them with a
second commit.
--
Alan Mackenzie (Nuremberg, Germany).
prev parent reply other threads:[~2022-09-27 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166360889903.6127.6574959318930089210@vcs2.savannah.gnu.org>
[not found] ` <20220919173459.EC224C00872@vcs2.savannah.gnu.org>
[not found] ` <87pmfrqjvc.fsf@gnus.org>
2022-09-27 8:47 ` bug#57911: master 60102016e4: Abolish max-specpdl-size (bug#57911) Alan Mackenzie
[not found] ` <YzK4s1X++EmI6CL+@ACM>
2022-09-27 9:01 ` Mattias Engdegård
2022-09-27 10:14 ` Alan Mackenzie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzLNH+kZl5JcmUbR@ACM \
--to=acm@muc.de \
--cc=57911@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).