From: Thomas Klausner <wiz@gatalith.at>
To: 57949@debbugs.gnu.org
Subject: bug#57949: git head; unportable test(1) operator
Date: Tue, 20 Sep 2022 09:08:52 +0200 [thread overview]
Message-ID: <YylnBD+BJedo03hB@yt.nih.at> (raw)
Hi!
In
https://github.com/emacs-mirror/emacs/commit/7c8a131984ab47349381975dead1712ae25ae2c6
Makefile.in started using "==" as test(1) comparison operator.
This is not portable, only bash supports it. POSIX mandates "=".
Please apply the following patch:
--- Makefile.in.orig 2022-09-19 23:17:34.000000000 +0000
+++ Makefile.in
@@ -417,7 +417,7 @@ sanity-check:
@v=$$(src/emacs${EXEEXT} --batch --eval \
'(progn (defun f (n) (if (= 0 n) 1 (* n (f (- n 1))))) (princ (f 10)))' \
2> /dev/null); \
- [ "X$$v" == "X3628800" ] && exit 0; \
+ [ "X$$v" = "X3628800" ] && exit 0; \
echo; \
echo " \"make ${make-target}\" succeeded, but Emacs is not functional."; \
cat Makefile | \
Thanks,
Thomas
next reply other threads:[~2022-09-20 7:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 7:08 Thomas Klausner [this message]
2022-09-20 9:22 ` bug#57949: git head; unportable test(1) operator Gregory Heytings
2022-09-20 11:51 ` Eli Zaretskii
2022-09-20 11:54 ` Gregory Heytings
2022-09-20 12:00 ` Eli Zaretskii
2022-09-20 14:20 ` Gregory Heytings
2022-09-20 15:24 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YylnBD+BJedo03hB@yt.nih.at \
--to=wiz@gatalith.at \
--cc=57949@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).