From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.bugs Subject: bug#56345: 29.0.50; [PATCH] Add column hiding to tabulated-list Date: Thu, 8 Sep 2022 21:14:00 +0300 Message-ID: References: <87pmg7tqps.fsf@gmail.com> <87v8py1k93.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37636"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/+ () (2022-06-11) Cc: 56345@debbugs.gnu.org, Thuna To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 08 21:20:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWN4d-0009cI-7y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 21:20:27 +0200 Original-Received: from localhost ([::1]:43400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWN4c-00084e-Bs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 15:20:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWN4F-00083v-8G for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 15:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43158) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWN4E-0003S7-Vm for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 15:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWN4E-0003kN-NH for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jean Louis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Sep 2022 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 56345-submit@debbugs.gnu.org id=B56345.166266476514322 (code B ref 56345); Thu, 08 Sep 2022 19:20:02 +0000 Original-Received: (at 56345) by debbugs.gnu.org; 8 Sep 2022 19:19:25 +0000 Original-Received: from localhost ([127.0.0.1]:60083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWN3c-0003iw-LI for submit@debbugs.gnu.org; Thu, 08 Sep 2022 15:19:24 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:42943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWN3Z-0003ia-0n for 56345@debbugs.gnu.org; Thu, 08 Sep 2022 15:19:23 -0400 Original-Received: from localhost ([::ffff:197.239.4.185]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000B5AC7.00000000631A4031.000031A8; Thu, 08 Sep 2022 12:19:13 -0700 Content-Disposition: inline In-Reply-To: <87v8py1k93.fsf@web.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241935 Archived-At: * Michael Heerdegen [2022-09-08 08:59]: > Thuna writes: > > > I don't know how `proced' and `ibuffer' specifically handles views, but > > I don't think it is a good idea to put the burden on external packages > > when tabulated-list is right there. Especially since this leads to a > > lot of (what I imagine to be) duplicated code across packages. > > Exactly. tabulated-list should implement this feature. > > > I don't exactly understand what you mean by "interface". Are you > > referring to the package which should be responsible for managing > > which columns are visible? > > No, I mean, how should column hiding happen? Should the user select > single columns interactively, or should we provide a way to define > restricted views? Maybe we can have both? It seems to me complex to hide columns as one would need to manipulated: - tabulated-list-format and - tabulated-list-entries One way to go would be: 1. Remember original format 2. Generate new format with column hidden 3. Remember original tabulated-list-entries 4. Modify tabulated-list-entries to remove the column 5. Refresh buffer 6. Revealing columns should restore original variables Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/