bug#57261: 29.0.50; X protocol error: XI_BadDevice (invalid Device parameter) on protocol request 131

[Jean Louis <bugs@gnu.support>]

* Robert Pluim <rpluim@gmail.com> [2022-08-17 17:43]:
> >>>>> On Wed, 17 Aug 2022 17:31:47 +0300, Jean Louis <bugs@gnu.support> said:
> 
>     Jean> I could not start X version of Emacs at all.
>     Jean> I am on latest git version.
> 
>     Jean> What worked is `emacs -nw --bg-daemon':
> 
>     Jean> but Emacs is not starting on X now.
> 
> Does this help:
> 
> diff --git a/src/xterm.c b/src/xterm.c
> index a40440e0da..a329ca59d0 100644
> --- a/src/xterm.c
> +++ b/src/xterm.c
> @@ -27654,6 +27654,8 @@ xi_select_hierarchy_events (struct x_display_info *dpyinfo)
>    memset (m, 0, l);
>    mask.mask_len = l;
>  
> +  mask.deviceid = XIAllDevices;
> +
>    XISetMask (m, XI_PropertyEvent);
>    XISetMask (m, XI_HierarchyChanged);
>    XISetMask (m, XI_DeviceChanged);

I did not try that, but I guess that there must be some recent change
in xterm, I guess it is something related to it.

And please Po Lu, revert it back that it works.

* ed9adafc0b..: Po Lu 2022-08-17 Avoid disabling device multiple times while handling XI attachment events
commit ed9adafc0bdcfc2c79534282f888df3b250db329
Author: Po Lu <luangruo@yahoo.com>
Date:   Wed Aug 17 10:20:25 2022 +0800

  Avoid disabling device multiple times while handling XI attachment events
  
  * src/xterm.c (handle_one_xevent): Avoid disabling devices if we
  notice it has been disabled while handling XISlaveDetached or
  XISlaveAttached.


-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/