From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#44502: Date: Fri, 19 Aug 2022 13:05:24 +0000 Message-ID: References: <5aa738a4-cfd8-6c4e-3174-4489a289cca9@gmail.com> <878rnwi60h.fsf@quad> <83mtccqetc.fsf@gnu.org> <87leruhcdh.fsf@quad> <83y1vuoc5s.fsf@gnu.org> <87edxmha0b.fsf@quad> <83mtcanfhy.fsf@gnu.org> <87y1vtg3ok.fsf@quad> <83zgg0ecka.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11987"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44502@debbugs.gnu.org, andrei.elkin@pp.inet.fi To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 19 15:06:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oP1hW-0002sO-U9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Aug 2022 15:06:14 +0200 Original-Received: from localhost ([::1]:39094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP1hV-0006hy-T3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Aug 2022 09:06:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP1hK-0006dc-D7 for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 09:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP1hK-0006jh-4G for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 09:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oP1hJ-0001eK-Km for bug-gnu-emacs@gnu.org; Fri, 19 Aug 2022 09:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Aug 2022 13:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44502 X-GNU-PR-Package: emacs Original-Received: via spool by 44502-submit@debbugs.gnu.org id=B44502.16609143396311 (code B ref 44502); Fri, 19 Aug 2022 13:06:01 +0000 Original-Received: (at 44502) by debbugs.gnu.org; 19 Aug 2022 13:05:39 +0000 Original-Received: from localhost ([127.0.0.1]:57562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oP1gw-0001dj-Tf for submit@debbugs.gnu.org; Fri, 19 Aug 2022 09:05:39 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:48017 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1oP1gq-0001dQ-TL for 44502@debbugs.gnu.org; Fri, 19 Aug 2022 09:05:36 -0400 Original-Received: (qmail 7866 invoked by uid 3782); 19 Aug 2022 13:05:26 -0000 Original-Received: from acm.muc.de (p4fe158a9.dip0.t-ipconnect.de [79.225.88.169]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 19 Aug 2022 15:05:25 +0200 Original-Received: (qmail 6863 invoked by uid 1000); 19 Aug 2022 13:05:24 -0000 Content-Disposition: inline In-Reply-To: <83zgg0ecka.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240204 Archived-At: Hello, Eli. On Fri, Aug 19, 2022 at 13:45:57 +0300, Eli Zaretskii wrote: > Ping! Any progress with this bug? I haven't been able to reproduce the bug, but understand fairly well what must have caused it. I also haven't heard back from the OP since sending him a proposed patch last Sunday. Since the patch is fairly simple and obvious, also non-dangerous, how about just installing it on the release branch? > > I think the following fix to the assert should indeed be a "safe" fix, > > suitable for Emacs-28. Could you possibly apply it, please, and try to > > recreate the error. If you don't manage to recreate the error, the bug > > is probably "fixed". > > diff --git a/src/window.c b/src/window.c > > index 2576b66a18..35ec2a1f90 100644 > > --- a/src/window.c > > +++ b/src/window.c > > @@ -554,7 +554,9 @@ select_window (Lisp_Object window, Lisp_Object norecord, > > frame is active. */ > > Fselect_frame (frame, norecord); > > /* Fselect_frame called us back so we've done all the work already. */ > > - eassert (EQ (window, selected_window)); > > + eassert (EQ (window, selected_window) > > + || (EQ (window, f->minibuffer_window) > > + && NILP (Fminibufferp (XWINDOW (window)->contents, Qt)))); > > return window; > > } > > else -- Alan Mackenzie (Nuremberg, Germany).