From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame Date: Wed, 6 Jul 2022 19:05:44 +0000 Message-ID: References: <83iloc8yzs.fsf@gnu.org> <83h73w8f7i.fsf@gnu.org> <83zghn7ckd.fsf@gnu.org> <83zghm5evt.fsf@gnu.org> <878rp6qd9t.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9826"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, Eli Zaretskii , 56305@debbugs.gnu.org, monnier@iro.umontreal.ca To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 21:06:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9AM7-0002N3-T6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 21:06:35 +0200 Original-Received: from localhost ([::1]:37634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9AM6-0006hJ-D6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 15:06:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9ALb-0006ef-UK for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 15:06:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33063) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9ALa-0005WB-4v for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 15:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9ALZ-0001UR-W6 for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 15:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 19:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56305 X-GNU-PR-Package: emacs Original-Received: via spool by 56305-submit@debbugs.gnu.org id=B56305.16571343575716 (code B ref 56305); Wed, 06 Jul 2022 19:06:01 +0000 Original-Received: (at 56305) by debbugs.gnu.org; 6 Jul 2022 19:05:57 +0000 Original-Received: from localhost ([127.0.0.1]:55193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9ALU-0001U8-VO for submit@debbugs.gnu.org; Wed, 06 Jul 2022 15:05:57 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:37849 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1o9ALP-0001Tn-Mm for 56305@debbugs.gnu.org; Wed, 06 Jul 2022 15:05:55 -0400 Original-Received: (qmail 96504 invoked by uid 3782); 6 Jul 2022 19:05:45 -0000 Original-Received: from acm.muc.de (p4fe15bd4.dip0.t-ipconnect.de [79.225.91.212]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 06 Jul 2022 21:05:45 +0200 Original-Received: (qmail 9051 invoked by uid 1000); 6 Jul 2022 19:05:44 -0000 Content-Disposition: inline In-Reply-To: <878rp6qd9t.fsf@igel.home> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236291 Archived-At: Hello, Andreas. On Wed, Jul 06, 2022 at 20:58:22 +0200, Andreas Schwab wrote: > On Jul 06 2022, Alan Mackenzie wrote: > > diff --git a/src/minibuf.c b/src/minibuf.c > > index 0fc7f2caa1..7723167d4d 100644 > > --- a/src/minibuf.c > > +++ b/src/minibuf.c > > @@ -896,6 +896,10 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, > > /* Don't allow the user to undo past this point. */ > > bset_undo_list (current_buffer, Qnil); > > + /* Ensure that the minibuffer frame has the window-system focus. > > + This is sometimes needed for minibuffer-only frames. */ > > + Fx_focus_frame (mini_frame, Qt); > Can't this steal focus from unrelated windows? Not obviously. We're about to run the recursive edit for read_minibuf, so the frame with the mini-window should have the focus anyway. The only possibility of theft that I see is if a normal frame already has its focus redirected to a minibuffer frame. In that case the normal frame will lose focus. I don't think this will happen, or if it does, it won't be serious. > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different." -- Alan Mackenzie (Nuremberg, Germany).