From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#6617: linux kernel C style (fwd) Date: Wed, 27 Apr 2022 19:17:52 +0000 Message-ID: References: <87ee9z4g00.fsf@gnus.org> <871r5yyl8p.fsf@melete.silentflame.com> <874katvogm.fsf@gnus.org> <87r15uxn0z.fsf@melete.silentflame.com> <8735i241y0.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 6617-done@debbugs.gnu.org, Dan Nicolaescu , Lars Ingebrigtsen , Dimitrios Apostolou , acm@muc.de To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 27 21:19:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njnC7-0003Lj-5j for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 21:19:23 +0200 Original-Received: from localhost ([::1]:32900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njnC6-00068B-1W for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 15:19:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njnBn-0005yv-4y for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 15:19:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njnBm-0001Hr-M7; Wed, 27 Apr 2022 15:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njnBm-0008Jl-Ha; Wed, 27 Apr 2022 15:19:02 -0400 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Wed, 27 Apr 2022 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 6617 X-GNU-PR-Package: emacs,cc-mode Mail-Followup-To: 6617@debbugs.gnu.org, acm@muc.de, jimis@gmx.net Original-Received: via spool by 6617-done@debbugs.gnu.org id=D6617.165108708331895 (code D ref 6617); Wed, 27 Apr 2022 19:19:02 +0000 Original-Received: (at 6617-done) by debbugs.gnu.org; 27 Apr 2022 19:18:03 +0000 Original-Received: from localhost ([127.0.0.1]:44437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njnAo-0008IN-O5 for submit@debbugs.gnu.org; Wed, 27 Apr 2022 15:18:02 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:25453 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1njnAm-0008Hk-02 for 6617-done@debbugs.gnu.org; Wed, 27 Apr 2022 15:18:01 -0400 Original-Received: (qmail 14016 invoked by uid 3782); 27 Apr 2022 19:17:53 -0000 Original-Received: from acm.muc.de (p4fe15b5b.dip0.t-ipconnect.de [79.225.91.91]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 27 Apr 2022 21:17:53 +0200 Original-Received: (qmail 14655 invoked by uid 1000); 27 Apr 2022 19:17:52 -0000 Content-Disposition: inline In-Reply-To: <8735i241y0.fsf@melete.silentflame.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230814 Archived-At: Hello, everybody. On Sun, Apr 24, 2022 at 14:16:23 -0700, Sean Whitton wrote: > Hello Alan, > On Sun 24 Apr 2022 at 02:50PM GMT, Alan Mackenzie wrote: > > After a bit of thought, I agree with you. I think here it is better > > just to add the setting of indent-tabs-mode to the "linux" style. Most > > users of "linux" will have that variable set to t one way or another, > > and so won't notice. > > There will be a few users using the style for non-Linux projects, who > > will be used to indent-tabs-mode being nil. That is just unfortunate. > > I think the balance of benefits and problems comes down on the side of > > this abrupt change. > Right. > > I intend to apply the following patch to cc-styles.el soon. If you > > want to test it you're very welcome, but please note that since it > > changes a variable, the amended CC Mode should be the first CC Mode > > you load in the Emacs session. (Otherwise, you'll need to do fancy > > things with `makunbound' before loading the new CC Mode.) > I'm not in the middle of any C projects using the Linux style atm, so I > don't think I'll be able to test, but your patch looks basically > equivalent to the "linux-tabs" thing I was doing, so probably doesn't > need a lot of testing. Thanks for thinking this one over! I've now committed the change to cc-styles.el, and am closing the bug with this post. > -- > Sean Whitton -- Alan Mackenzie (Nuremberg, Germany).