From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#21409: 24.5; Wrong syntactic information for two line statement in an arglist Date: Sat, 23 Apr 2022 14:23:55 +0000 Message-ID: References: <87eek7taft.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35193"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 21409@debbugs.gnu.org To: Gulshan Singh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 23 16:25:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1niGhF-000945-2W for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Apr 2022 16:25:13 +0200 Original-Received: from localhost ([::1]:53618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1niGhD-0002Pr-JL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Apr 2022 10:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niGh5-0002PO-72 for bug-gnu-emacs@gnu.org; Sat, 23 Apr 2022 10:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1niGh4-0002Q3-Nx; Sat, 23 Apr 2022 10:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1niGh4-0000Is-Kc; Sat, 23 Apr 2022 10:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sat, 23 Apr 2022 14:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21409 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 21409-submit@debbugs.gnu.org id=B21409.16507238451099 (code B ref 21409); Sat, 23 Apr 2022 14:25:02 +0000 Original-Received: (at 21409) by debbugs.gnu.org; 23 Apr 2022 14:24:05 +0000 Original-Received: from localhost ([127.0.0.1]:56853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niGg9-0000Hf-3v for submit@debbugs.gnu.org; Sat, 23 Apr 2022 10:24:05 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:60377 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1niGg7-0000H8-Ho for 21409@debbugs.gnu.org; Sat, 23 Apr 2022 10:24:04 -0400 Original-Received: (qmail 3909 invoked by uid 3782); 23 Apr 2022 14:23:56 -0000 Original-Received: from acm.muc.de (p2e5d5134.dip0.t-ipconnect.de [46.93.81.52]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 23 Apr 2022 16:23:56 +0200 Original-Received: (qmail 6245 invoked by uid 1000); 23 Apr 2022 14:23:55 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230490 Archived-At: Hello, Gulshan. Sorry I've been a bit busy the last two weeks, even if mainly on other Emacs things. On Sat, Apr 09, 2022 at 14:43:32 -0700, Gulshan Singh wrote: > Hi Alan, thanks for the patch! I've been very busy, but I just got > around to applying it and testing it out. > > I've hacked up the following patch, which introduces the new Line-Up > > function c-lineup-arglist-+. To use it (temporarily) do C-c C-o RET on > > the .baz() line, and change the setting for arglist-cont-nonempty from > > (c-lineup-gcc-asm-reg c-lineup-arglist) > > to > > (c-lineup-gcc-asm-reg c-lineup-arglist-+ c-lineup-arglist) > I think you meant `(c-lineup-gcc-asm-reg c-lineup-argcont-+ > c-lineup-arglist)` (or you meant to define the function name as > `c-lineup-arglist-+` instead of `c-lineup-argcont-+`, not sure). I think you're right, here! > In any case, I tested it and it works great! Is this patch something > that could be merged upstream? Thanks! I'm part way through more thorough testing, and I'm hoping to commit it this weekend (after having updated the documentation). It will most definitely appear in the next major Emacs version, Emacs 29.1, when it appears (in around 1 - 2 years time). -- Alan Mackenzie (Nuremberg, Germany).