From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#54098: 29.0.50; Unexec build broken Date: Thu, 24 Feb 2022 17:38:54 +0000 Message-ID: References: <87wnhnbcrk.fsf.ref@yahoo.com> <87wnhnbcrk.fsf@yahoo.com> <87a6ejb9ra.fsf@yahoo.com> <87wnhn9mm2.fsf@yahoo.com> <878ru186ac.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16217"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, 54098-done@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 24 18:40:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNI68-0003xq-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 18:40:12 +0100 Original-Received: from localhost ([::1]:33732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNI67-00085B-3e for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 12:40:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNI5y-00084e-LP for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 12:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56402) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNI5y-0001Kn-Bc for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 12:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNI5x-0004lI-T2 for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 12:40:01 -0500 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Feb 2022 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54098 X-GNU-PR-Package: emacs Mail-Followup-To: 54098@debbugs.gnu.org, acm@muc.de, luangruo@yahoo.com Original-Received: via spool by 54098-done@debbugs.gnu.org id=D54098.164572434418210 (code D ref 54098); Thu, 24 Feb 2022 17:40:01 +0000 Original-Received: (at 54098-done) by debbugs.gnu.org; 24 Feb 2022 17:39:04 +0000 Original-Received: from localhost ([127.0.0.1]:50293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNI52-0004jd-Ee for submit@debbugs.gnu.org; Thu, 24 Feb 2022 12:39:04 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:28185 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nNI50-0004j8-Fn for 54098-done@debbugs.gnu.org; Thu, 24 Feb 2022 12:39:03 -0500 Original-Received: (qmail 52394 invoked by uid 3782); 24 Feb 2022 17:38:55 -0000 Original-Received: from acm.muc.de (p4fe15397.dip0.t-ipconnect.de [79.225.83.151]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 24 Feb 2022 18:38:54 +0100 Original-Received: (qmail 8445 invoked by uid 1000); 24 Feb 2022 17:38:54 -0000 Content-Disposition: inline In-Reply-To: <878ru186ac.fsf@yahoo.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227590 Archived-At: Hello, Po. On Thu, Feb 24, 2022 at 08:19:55 +0800, Po Lu wrote: > Alan Mackenzie writes: > > I've changed approach. The previous code was continually overwriting > > Lisp objects with themselves, particularly where it didn't need doing. > > This is surely (??) what was happening in the pure storage. > > > > I've rewritten byte-run-strip-symbol-positions, so that changes are only > > attempted where they're needed, i.e. where a symbol with position gets > > replaced by its bare symbol. > > > > I'm hoping that this will now work OK, though I don't have a setup using > > unexec to test it with. Would you please test it. > > > > I'm tending to the view that we need to make this function available to > > Lisp hackers. I think we need both varieties of the function (the one > > that makes a copy, and the one that modifies in situ), and that they > > should be called simply strip-symbol-positions and > > n-strip-symbol-positions (like reverse and nreverse). > > > > Anyhow, here's the patch: > Bootstrapping an unexec build works now with your patch. Thanks. I've committed the patch to master, and I'm closing the bug with this post. -- Alan Mackenzie (Nuremberg, Germany).