unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Po Lu <luangruo@yahoo.com>
Cc: acm@muc.de, 54098-done@debbugs.gnu.org
Subject: bug#54098: 29.0.50; Unexec build broken
Date: Thu, 24 Feb 2022 17:38:54 +0000	[thread overview]
Message-ID: <YhfCrjGEzHRTr0zf@ACM> (raw)
In-Reply-To: <878ru186ac.fsf@yahoo.com>

Hello, Po.

On Thu, Feb 24, 2022 at 08:19:55 +0800, Po Lu wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > I've changed approach.  The previous code was continually overwriting
> > Lisp objects with themselves, particularly where it didn't need doing.
> > This is surely (??) what was happening in the pure storage.
> >
> > I've rewritten byte-run-strip-symbol-positions, so that changes are only
> > attempted where they're needed, i.e. where a symbol with position gets
> > replaced by its bare symbol.
> >
> > I'm hoping that this will now work OK, though I don't have a setup using
> > unexec to test it with.  Would you please test it.
> >
> > I'm tending to the view that we need to make this function available to
> > Lisp hackers.  I think we need both varieties of the function (the one
> > that makes a copy, and the one that modifies in situ), and that they
> > should be called simply strip-symbol-positions and
> > n-strip-symbol-positions (like reverse and nreverse).
> >
> > Anyhow, here's the patch:

> Bootstrapping an unexec build works now with your patch.  Thanks.

I've committed the patch to master, and I'm closing the bug with this
post.

-- 
Alan Mackenzie (Nuremberg, Germany).





      reply	other threads:[~2022-02-24 17:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87wnhnbcrk.fsf.ref@yahoo.com>
2022-02-22  7:07 ` bug#54098: 29.0.50; Unexec build broken Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-22  8:12   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-22 11:15     ` Alan Mackenzie
2022-02-22 11:17       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-23 21:23         ` Alan Mackenzie
2022-02-24  0:19           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-24 17:38             ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhfCrjGEzHRTr0zf@ACM \
    --to=acm@muc.de \
    --cc=54098-done@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).