From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#16097: [PATCH] Treat windows on other spaces as not visible in Cocoa Date: Tue, 1 Feb 2022 22:48:02 +0000 Message-ID: References: <87zgniphrc.fsf@gnus.org> <87czkdfner.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34980"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 16097@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 02 15:46:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFGuM-0008q0-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Feb 2022 15:46:55 +0100 Original-Received: from localhost ([::1]:48492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFGuK-0002Kn-VX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Feb 2022 09:46:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFGNb-0004k7-L0 for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 09:13:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFGNa-0004e4-9K for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 09:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nFGNa-0000rs-4v for bug-gnu-emacs@gnu.org; Wed, 02 Feb 2022 09:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Feb 2022 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16097 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16097-submit@debbugs.gnu.org id=B16097.16438111783320 (code B ref 16097); Wed, 02 Feb 2022 14:13:02 +0000 Original-Received: (at 16097) by debbugs.gnu.org; 2 Feb 2022 14:12:58 +0000 Original-Received: from localhost ([127.0.0.1]:51889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFGNW-0000rU-Bg for submit@debbugs.gnu.org; Wed, 02 Feb 2022 09:12:58 -0500 Original-Received: from outbound.soverin.net ([116.202.126.228]:55653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFGNQ-0000rB-KE for 16097@debbugs.gnu.org; Wed, 02 Feb 2022 09:12:52 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 11D593D69; Tue, 1 Feb 2022 22:48:05 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1643755684; bh=9Ds2/50MxthXV1LHH4iYWUQCNCEMEjBwnE+9kUYdBMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IW/lSx5GonV25i/rBjh18mmK1mavdg47nmEvHpLBn4MRxeQCBtJHMnkHcR/VRBoPw q+mq9zLCetLI9RlNW/DXZnrgKIe54nrpjn4vpMPc18vtrlWT2Ii+eOMK9YXBtq7bA/ Pm3rjS3/dKvV2nfXnwHLTwNbo9pEMrFgGNetP0JKTFgV79kLbK4eT3I71sZIkId1Zp PzLoc+dMYl3CQsltRV6P5GAHLnjxhh6eevOE/mZwjE22xzW2vGY18WZO1VdBpe2/gp uxRDdmCKXSymMMdoGHO+TuAdS8KntY3SOW27ex/PUDK4JODIkdsalmzSnbiUmcb5YW s5Xsog+Ckr+xQ== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95) (envelope-from ) id 1nF1wQ-0002NK-4c; Tue, 01 Feb 2022 22:48:02 +0000 Mail-Followup-To: Alan Third , Robert Pluim , Lars Ingebrigtsen , 16097@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <87czkdfner.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225793 Archived-At: (Apparently this failed to send correctly the first time. I know Robert already replied to it, but it's not in the mailing list archive, and I don't see my second follow up to this bug either.) On Thu, Jan 27, 2022 at 12:06:36PM +0100, Robert Pluim wrote: > >>>>> On Wed, 26 Jan 2022 17:46:15 +0100, Lars Ingebrigtsen said: > > Lars> David Benjamin writes: > >> Here's a patch for something that's been bugging me. This makes Cmd-` > >> cycle through only the current space's windows, which is consistent > >> with other programs on OS X. It also matches the behavior of > >> other-frame on X11 for window managers that implement virtual desktops > >> by mapping and unmapping windows. The patch is attached. > > Lars> Perhaps Alan has a comment here; added to the CCs. > > Please let's apply this. Please. Pretty please. Pretty please with sugar on > top. Please. > > Iʼve rebased it to master and attach it here. > > Did I mention I like it? I'm afraid I don't much. It looks like the updateVisibility method doesn't actually do enough to replace the windowDidBecomeKey method. It also needs a good clean. For example there's a hunk that appears to just be removing a single blank line and most of the #ifdef's are redundant. I guess some of the weirdness in it is just because it's so old. Is this really how other terms work, where visibility is tied into which virtual desktop is "active"? I'm not against this behaviour, I just don't like the look of this particular patch very much. -- Alan Third