From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly Date: Tue, 28 Dec 2021 11:43:00 +0000 Message-ID: References: <20171017085859.GA633@breton.holly.idiocy.org> <20171018195034.GB8705@breton.holly.idiocy.org> <871r7mr6az.fsf@idiocy.org> <87wnjwnz0n.fsf@idiocy.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="40nfYXAYgqJmNOgt" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13242"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 28512-done@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 28 12:44:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2Atw-0003IY-53 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 12:44:20 +0100 Original-Received: from localhost ([::1]:60376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2Atu-00085x-AB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 06:44:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2Ate-00084Y-0W for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 06:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2Atd-00018g-Mk for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 06:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2Atd-0000ta-LN for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 06:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Dec 2021 11:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28512 X-GNU-PR-Package: emacs Original-Received: via spool by 28512-done@debbugs.gnu.org id=D28512.16406917923376 (code D ref 28512); Tue, 28 Dec 2021 11:44:01 +0000 Original-Received: (at 28512-done) by debbugs.gnu.org; 28 Dec 2021 11:43:12 +0000 Original-Received: from localhost ([127.0.0.1]:45230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Asq-0000sN-8D for submit@debbugs.gnu.org; Tue, 28 Dec 2021 06:43:12 -0500 Original-Received: from outbound.soverin.net ([116.202.126.228]:44037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Aso-0000ro-KI for 28512-done@debbugs.gnu.org; Tue, 28 Dec 2021 06:43:11 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 9A722807; Tue, 28 Dec 2021 11:43:03 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1640691783; bh=J1DPEDwoc2o3AckwY9aL9d980zz527bv+WTFmV6VukI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=knSicNPSkwz2gW2xtlZB4NF74dF4+4mCVySNaXO0sEybZdpACbgH5wVnh19CBzCLI YWmO4OaA5nYhy1+BztZlIUugvctG032HYz2KFU6SL4f2dVJQN4x/e2wdRzQ/AVS7Vy HVVKF8GUIhthq6vS21kKRqKTKMVlSXVgPTLsq8wRolRJJzBXJJT699Qm8PNi0WWB6q WzY0Hx+eZZGYFu+iZBrX1rKPp0gdV1IU5bFlOeL+RXVmfSvj9lbTuqAOAVsMto9Efj MtGWSkAHcywsK7s0jPovtIwaNtmdiGOKg/78cRBhZBUbONG33qJKjMjmiJF2NSaneG 8DgS3Fu16J8HA== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1n2Ase-0022wd-6P; Tue, 28 Dec 2021 11:43:00 +0000 Mail-Followup-To: Alan Third , Aaron Jensen , 28512-done@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223244 Archived-At: --40nfYXAYgqJmNOgt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 23, 2021 at 01:19:34PM -0500, Aaron Jensen wrote: > On Thu, Dec 23, 2021 at 11:09 AM Alan Third wrote: > > Looks like we can set hasShadow to NO. Maybe we want to do that to > > undecorated child frames, or something? > > That's probably reasonable. I like it for emacs-mini-frame, but having > the shadows on company posframe is silly, so I'm fine not having it > for anything. Please try the attached, it's completely untested. -- Alan Third --40nfYXAYgqJmNOgt Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Remove-macOS-drop-shadows-on-some-frames-bug-28512.patch" >From 0b9c068ae1186b0831495d82f5a7199da5f8401a Mon Sep 17 00:00:00 2001 From: Alan Third Date: Tue, 28 Dec 2021 11:36:46 +0000 Subject: [PATCH] Remove macOS drop-shadows on some frames (bug#28512) * src/nsterm.m ([EmacsWindow setParentChildRelationships]): Remove shadows on undecorated child frames. --- src/nsterm.m | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/nsterm.m b/src/nsterm.m index f79e271a98..6178dd80bb 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8435,6 +8435,15 @@ - (void)setParentChildRelationships #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1070 [ourView updateCollectionBehavior]; #endif + + /* Child frames are often used in ways that may mean they should + "disappear" into the contents of the parent frame. macOs's + drop-shadows break this effect, so remove them on undecorated + child frames. */ + if (parentFrame && FRAME_UNDECORATED (ourFrame)) + [self setHasShadow:NO]; + else + [self setHasShadow:YES]; #endif -- 2.33.0 --40nfYXAYgqJmNOgt--