From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#52298: 29.0.50; Frequent redisplay cycles induced by c-type-finder-timer-func timer in CC Mode Date: Sun, 12 Dec 2021 19:05:45 +0000 Message-ID: References: <838rwss37v.fsf@gnu.org> <83tuffr2qd.fsf@gnu.org> <83zgp7p2x1.fsf@gnu.org> <83v8zvovcw.fsf@gnu.org> <837dcap4jt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5999"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52298@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 20:06:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwUB3-0001Lb-Ta for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 20:06:29 +0100 Original-Received: from localhost ([::1]:40648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwUB2-0002Ny-DI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 14:06:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwUAe-0002NZ-TP for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 14:06:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwUAc-0008UB-Sk for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 14:06:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwUAc-0006p4-NS for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 14:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52298 X-GNU-PR-Package: emacs Original-Received: via spool by 52298-submit@debbugs.gnu.org id=B52298.163933595626208 (code B ref 52298); Sun, 12 Dec 2021 19:06:02 +0000 Original-Received: (at 52298) by debbugs.gnu.org; 12 Dec 2021 19:05:56 +0000 Original-Received: from localhost ([127.0.0.1]:53158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwUAW-0006od-4o for submit@debbugs.gnu.org; Sun, 12 Dec 2021 14:05:56 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:58161 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1mwUAU-0006oO-GK for 52298@debbugs.gnu.org; Sun, 12 Dec 2021 14:05:55 -0500 Original-Received: (qmail 53639 invoked by uid 3782); 12 Dec 2021 19:05:47 -0000 Original-Received: from acm.muc.de (p2e5d5b9a.dip0.t-ipconnect.de [46.93.91.154]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 12 Dec 2021 20:05:47 +0100 Original-Received: (qmail 26662 invoked by uid 1000); 12 Dec 2021 19:05:45 -0000 Content-Disposition: inline In-Reply-To: <837dcap4jt.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222254 Archived-At: Hello, Eli. On Sun, Dec 12, 2021 at 11:15:34 +0200, Eli Zaretskii wrote: > > Date: Sun, 12 Dec 2021 08:58:08 +0000 > > Cc: 52298@debbugs.gnu.org, acm@muc.de > > From: Alan Mackenzie > > > > So, I suggest I write a commit message and commit that patch. > > > Which patch? I'm afraid I'm missing something here. > > This one, the one that should prevent excessive incursions into the > > redisplay engine when a text property gets set whilst > > inhibit-modification-hooks is set: > No, this cannot be used as-is, because when face properties change, we > do want redisplay to take notice, of course. I guess that's why > inhibit-modification-hooks doesn't prevent incrementing the > modification tick when text properties are changed in the first place: > it's not feasible to know which text properties affect the display and > which don't. No one expected text properties irrelevant to display to > be put on buffer text with such high frequency. Yes, that makes sense, thanks. Maybe I'll put a comment in there saying that. > If you don't have any other ideas, I guess we will have to live with > this. Too bad. > (Sorry, but I like CC Mode less and less with every Emacs release, due > to changes like this one.) This particular feature simply hasn't worked out well. If the background scanning were to complete in a few seconds, it wouldn't be too bad. But nearly two minutes on a modern (well, 4½ yo) machine for just one buffer, with the annoyance of the "stuttering", is not worth the gain. What we have is effectively the entire buffer getting half-fontified in the background. That's not what JIT fontification is supposed to be about. So, in the next few days sometime, I will revert most of this change. A useful and harmless piece of it (fontifying a newly found type throughout the buffer when it is encountered in "normal" jit fontification), I plan to leave in. That will get rid of that timer and all the background scanning it triggered. -- Alan Mackenzie (Nuremberg, Germany).