From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, 52298@debbugs.gnu.org
Subject: bug#52298: 29.0.50; Frequent redisplay cycles induced by c-type-finder-timer-func timer in CC Mode
Date: Sun, 12 Dec 2021 08:58:08 +0000 [thread overview]
Message-ID: <YbW5oEEy24L1xt1b@ACM> (raw)
In-Reply-To: <83v8zvovcw.fsf@gnu.org>
Hello, Eli.
On Sat, Dec 11, 2021 at 20:21:51 +0200, Eli Zaretskii wrote:
> > Date: Sat, 11 Dec 2021 17:04:28 +0000
> > Cc: 52298@debbugs.gnu.org
> > From: Alan Mackenzie <acm@muc.de>
> > So, I suggest I write a commit message and commit that patch.
> Which patch? I'm afraid I'm missing something here.
This one, the one that should prevent excessive incursions into the
redisplay engine when a text property gets set whilst
inhibit-modification-hooks is set:
diff --git a/src/textprop.c b/src/textprop.c
index d7d6a66923..d91b8624ef 100644
--- a/src/textprop.c
+++ b/src/textprop.c
@@ -85,10 +85,13 @@ modify_text_properties (Lisp_Object buffer,
Lisp_Object start, Lisp_Object end)
prepare_to_modify_buffer_1 (b, e, NULL);
- BUF_COMPUTE_UNCHANGED (buf, b - 1, e);
- if (MODIFF <= SAVE_MODIFF)
- record_first_change ();
- modiff_incr (&MODIFF);
+ if (!inhibit_modification_hooks)
+ {
+ BUF_COMPUTE_UNCHANGED (buf, b - 1, e);
+ if (MODIFF <= SAVE_MODIFF)
+ record_first_change ();
+ modiff_incr (&MODIFF);
+ }
bset_point_before_scroll (current_buffer, Qnil);
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2021-12-12 8:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 7:46 bug#52298: 29.0.50; Frequent redisplay cycles induced by c-type-finder-timer-func timer in CC Mode Eli Zaretskii
2021-12-06 20:53 ` Alan Mackenzie
2021-12-07 12:58 ` Eli Zaretskii
2021-12-07 19:58 ` Alan Mackenzie
2021-12-07 20:16 ` Eli Zaretskii
2021-12-08 20:15 ` Alan Mackenzie
2021-12-09 7:08 ` Eli Zaretskii
2021-12-09 20:11 ` Alan Mackenzie
2021-12-09 20:38 ` Eli Zaretskii
2021-12-10 18:16 ` Alan Mackenzie
2021-12-10 18:51 ` Eli Zaretskii
2021-12-10 22:52 ` Alan Mackenzie
2021-12-11 7:59 ` Eli Zaretskii
2021-12-11 14:52 ` Alan Mackenzie
2021-12-11 15:38 ` Eli Zaretskii
2021-12-11 17:04 ` Alan Mackenzie
2021-12-11 18:21 ` Eli Zaretskii
2021-12-12 8:58 ` Alan Mackenzie [this message]
2021-12-12 9:15 ` Eli Zaretskii
2021-12-12 19:05 ` Alan Mackenzie
2021-12-12 19:21 ` Eli Zaretskii
2021-12-13 14:19 ` Alan Mackenzie
2021-12-12 23:31 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-13 14:25 ` Alan Mackenzie
2021-12-19 14:38 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbW5oEEy24L1xt1b@ACM \
--to=acm@muc.de \
--cc=52298@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).