From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#51411: NS port cleanups Date: Tue, 26 Oct 2021 13:39:15 +0100 Message-ID: References: <87mtmwt3mc.fsf.ref@yahoo.com> <87mtmwt3mc.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28883"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51411@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 26 14:40:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfLkY-0007GK-Eh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 14:40:18 +0200 Original-Received: from localhost ([::1]:52358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfLkX-0000Hy-08 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 08:40:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfLkI-0000HY-HM for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 08:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfLkH-00042y-LC for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 08:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfLkH-0006Ct-IV for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 08:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Oct 2021 12:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51411 X-GNU-PR-Package: emacs Original-Received: via spool by 51411-submit@debbugs.gnu.org id=B51411.163525196323798 (code B ref 51411); Tue, 26 Oct 2021 12:40:01 +0000 Original-Received: (at 51411) by debbugs.gnu.org; 26 Oct 2021 12:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:45349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfLje-0006Bm-MF for submit@debbugs.gnu.org; Tue, 26 Oct 2021 08:39:22 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:52243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfLjc-0006Bc-Dx for 51411@debbugs.gnu.org; Tue, 26 Oct 2021 08:39:21 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 8F61DE3; Tue, 26 Oct 2021 12:39:18 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1635251958; bh=tlEO0fIROkeUI6WJiJdgs1MMIubCUvIRAz8i0x7wrHg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QLrBBlsDu9TRAowPA64Th+NFVuIisFuO+pe2ipjOfMAn8cfIBNPBAVWn7BuV2ffxM zNQKFaosU6MWU5oa7OtwZf6TmrQamw88/W+3HH/M0XmC0Yv0e8hSS3hLBpjIZp8f6/ HRhJvLWgFAXymI+t/HP9X0MzA8EXuWAMVCtUNUkd4ThyoWsw/GnY/GSQjqxzNLkJWR Z1wwjwLa1wTUjxoY6VykquBsBxqYCRLSaOHSsl+lOhAE9RaLroFgNTQJwa48aLhcu3 Wku72A+no1ti5zyNC0sDXsNH97xvVJCvmL/3lb5esg/gy9Z5O5lrUWr76i9YAld9te BHoqIsjseHJ0w== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mfLjX-000iLJ-Ur; Tue, 26 Oct 2021 13:39:15 +0100 Mail-Followup-To: Alan Third , Po Lu , 51411@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <87mtmwt3mc.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218379 Archived-At: On Tue, Oct 26, 2021 at 07:41:31PM +0800, Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > > Is there any reason to nest ns_focus? There are (according to Apple) > > performance reasons to not save the context unless you really need to. > > Right now it's used in the code that clips to the exact bounds of a > string, if a string's overhangs are already drawn. > > I couldn't find a cleaner way to do this, and that situation is rare, so > I think the performance problems will usually be avoided. Is this the code in ns_draw_glyph_string? > > I mean alt as defined by GNUstep in the quote I sent you in my last > > email. I don't think it's our job to say that GNUstep's choice of > > defaults is wrong and therefore do something that would be unexpected > > for a GNUstep user. > > Well, on every other platform Meta is on the alt on the users' keyboard. > Emacs in general doesn't conform to the platform expectations WRT to key > bindings, so I think being consistent with Emacs on other platforms is > more important here. I think we normally accept what the system tells us is Alt, or the nearest equivalent. In this case GNUstep tells us what it's understanding of the nearest equivalent (option) is, and I don't see any reason to override that. So please remove the changes to modifier keys. -- Alan Third