From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#51411: NS port cleanups Date: Sun, 31 Oct 2021 12:55:11 +0000 Message-ID: References: <87h7d4t0er.fsf@yahoo.com> <87ee86q7jm.fsf@yahoo.com> <87ilxhmlwc.fsf@yahoo.com> <87lf29jxeg.fsf@yahoo.com> <87v91digfm.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7455"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51411@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 31 13:56:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhANi-0001lT-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Oct 2021 13:56:14 +0100 Original-Received: from localhost ([::1]:48728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhANh-00024R-4w for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Oct 2021 08:56:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhANW-00022x-Sd for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 08:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhANW-0005z0-KK for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 08:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhANW-0007qF-IX for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 08:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Oct 2021 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51411-submit@debbugs.gnu.org id=B51411.163568492130086 (code B ref 51411); Sun, 31 Oct 2021 12:56:02 +0000 Original-Received: (at 51411) by debbugs.gnu.org; 31 Oct 2021 12:55:21 +0000 Original-Received: from localhost ([127.0.0.1]:59215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhAMq-0007pC-Ko for submit@debbugs.gnu.org; Sun, 31 Oct 2021 08:55:20 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:39929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhAMo-0007p2-6U for 51411@debbugs.gnu.org; Sun, 31 Oct 2021 08:55:19 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 69D4692; Sun, 31 Oct 2021 12:55:16 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1635684915; bh=tT5koUmHYT6dU9yYJpavbgxB/xmmG9Bli9e/xD9wGJc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wy+y8opFL0TkJeY2L1wKPFN6tQh2zEMdzgIVL3svQAk/WxjQjzv5Vmf0bkvj+y/5V jBisUdokhPBdRH6WDW+LS+SSBJE7rcYcRzUMia7Impy1qJiWBeZBdAN798CKpXaQeq hI4MAobo3hAHDPjz/9LFC/zZuU1YNeiJdWjBBWFC4669gsFSSB5ooZ7siPqz74mxHn 3B81ue0gjiiBrhVl87fqpzvw5SriyQiHLV4PAOgmErcFqb6jVP2j0z2EVC8QLUQ/Fc Yr+aTBQDSJU4/sxQx5mcMlfX3/YPIAGjlAcS2ONc2mr/vnZaOLUV1XwHC6wJ3tFFuF Zhv7iWU1epKaw== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mhAMh-0003UF-7a; Sun, 31 Oct 2021 12:55:11 +0000 Mail-Followup-To: Alan Third , Po Lu , 51411@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <87v91digfm.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218678 Archived-At: On Sun, Oct 31, 2021 at 07:26:05PM +0800, Po Lu wrote: > Alan Third writes: > > > I noticed that you removed all calls to ns_focus in > > ns_draw_window_cursor and thought you'd removed all calls to ns_focus, > > but now I see that's an older change. > > > > Is that a good idea? I think ns_draw_window_cursor is sometimes called > > without matching ns_update_begin/end calls, so it needs to focus, or am I > > misunderstanding the flow? > > I don't know if ns_draw_window_cursor is called outside > ns_update_begin/end, but if that's the case then I'm not sure how, for > instance, double buffering would work on the X port. Some drawing functions are definitely used outside ns_update_begin/end, at least in the NS port. Could you please put ns_focus calls back into ns_draw_window_cursor, just in case they are needed, and we can get these changes put into master and then maybe look at whether we need all these ns_focus calls as a separate task (it would certainly be nice if we could get rid of a few of them!). -- Alan Third