From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands Date: Sat, 2 Oct 2021 12:38:58 +0000 Message-ID: References: <831r54einq.fsf@gnu.org> <871r54xnds.fsf@gmail.com> <87ee933bcj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50946@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 02 14:40:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWeJT-0003bp-UD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Oct 2021 14:40:23 +0200 Original-Received: from localhost ([::1]:46134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWeJS-0001zk-AD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Oct 2021 08:40:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWeJ9-0001zc-Hc for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 08:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWeJ7-0003Jn-SQ for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 08:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWeJ7-00010o-Pz for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 08:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Oct 2021 12:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50946 X-GNU-PR-Package: emacs Original-Received: via spool by 50946-submit@debbugs.gnu.org id=B50946.16331783473822 (code B ref 50946); Sat, 02 Oct 2021 12:40:01 +0000 Original-Received: (at 50946) by debbugs.gnu.org; 2 Oct 2021 12:39:07 +0000 Original-Received: from localhost ([127.0.0.1]:58165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWeIE-0000zZ-Kt for submit@debbugs.gnu.org; Sat, 02 Oct 2021 08:39:06 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:40499 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1mWeIC-0000z1-Sd for 50946@debbugs.gnu.org; Sat, 02 Oct 2021 08:39:05 -0400 Original-Received: (qmail 58999 invoked by uid 3782); 2 Oct 2021 12:38:58 -0000 Original-Received: from acm.muc.de (p4fe15ae2.dip0.t-ipconnect.de [79.225.90.226]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 02 Oct 2021 14:38:58 +0200 Original-Received: (qmail 13977 invoked by uid 1000); 2 Oct 2021 12:38:58 -0000 Content-Disposition: inline In-Reply-To: <87ee933bcj.fsf@gmail.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216138 Archived-At: Hello, Joćo. On Sat, Oct 02, 2021 at 12:38:52 +0100, Joćo Tįvora wrote: > Alan Mackenzie writes: > > clumsy messing around with temporary buffers, file-attributes, and I stand by that description. It was accurate. > Also, if you want to converse, be polite. Your petty posturing doesn't > intimidate me. So go insult someone else. I respectfully request you to deal with the issues I have raised. If you want to direct disrespect at me, private email would probably be a better place. To be perfectly honest, I was shocked when I saw the state of the coding in that defun. I have not said on this list what I really think about it, and will not do so. I can only hope that you just threw something together as a proof of concept, and then forgot to change it into acceptable code before committing it. Or something like that. If so, an apology would be appropriate. You closed this bug without fixing it. There are corner cases the "fix" doesn't handle, which I pointed out earlier and you ignored. You closed the bug without even having the decency to ask me to check the patch first. That is not polite, and not the normal way things are done, here. I think that with hack-elisp-shorthands having been coded without attention to detail, there is a good chance the rest of this feature is similarly lacking in attention to detail, which is why I asked for an independent person to check. Eli seems to think this isn't a problem. You haven't fixed this bug. When you first closed it this afternoon, I assumed you did so by accident, since the -done@debbugs.gnu.org was on the Cc:. Your recent closing of this unfixed bug was clearly deliberate. I'm not going to get into a childish game with you, opening and closing this bug repeatedly. Instead, I invite you to calm down, think it over over the next few days, and consider whether such unfixed bugs are really the right thing for Emacs. > Joćo -- Alan Mackenzie (Nuremberg, Germany).