From: Michael Mauger <mmauger@protonmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tijs Mallaerts <tijs.mallaerts@gmail.com>,
"Michael R. Mauger" <michael@mauger.com>,
"25424@debbugs.gnu.org" <25424@debbugs.gnu.org>
Subject: bug#25424:
Date: Sat, 23 Mar 2019 01:43:49 +0000 [thread overview]
Message-ID: <YVfqS1USFNJCs8ghEFo1yJQX9bs5-7Ki18NXojNNXIxXw-UxFHcZ3s5KpUXkf3rFVQUebcicy3qhzJyQmmQiia1ZN2khICq00-B0sdkYUoQ=@protonmail.com> (raw)
In-Reply-To: <83d0mjrqx4.fsf@gnu.org>
I've reviewed the issue. The fix is more appropriate in `sql-end-of-statement'. I'll commit a change to implement this.
Thanks
--
MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, March 22, 2019 9:15 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Tijs Mallaerts tijs.mallaerts@gmail.com
>
> > Date: Fri, 22 Mar 2019 11:33:08 +0100
> > Could someone please verify if this patch is ok?
>
> Sorry for the delay, CC'ing the relevant maintainer.
>
> Michael, could you please look at the patch proposed in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25424#10?
>
> Thanks.
next prev parent reply other threads:[~2019-03-23 1:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 22:53 bug#25424: 25.1; sql-mode, product mysql: sql-end-of-statement: Wrong type argument: stringp, nil Tijs Mallaerts
2019-01-11 22:12 ` bug#25424: [PATCH] Add mysql terminator to sql-product-alist Tijs Mallaerts
2019-02-06 10:49 ` bug#25424: " Tijs Mallaerts
2019-03-22 10:33 ` bug#25424: Tijs Mallaerts
2019-03-22 13:15 ` bug#25424: Eli Zaretskii
2019-03-23 1:43 ` Michael Mauger [this message]
2019-03-23 6:56 ` bug#25424: Eli Zaretskii
2019-03-24 19:31 ` bug#25424: Michael Mauger
2019-03-24 19:52 ` bug#25424: Eli Zaretskii
2019-03-25 19:32 ` bug#25424: Tijs Mallaerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='YVfqS1USFNJCs8ghEFo1yJQX9bs5-7Ki18NXojNNXIxXw-UxFHcZ3s5KpUXkf3rFVQUebcicy3qhzJyQmmQiia1ZN2khICq00-B0sdkYUoQ=@protonmail.com' \
--to=mmauger@protonmail.com \
--cc=25424@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael@mauger.com \
--cc=tijs.mallaerts@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).