From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands Date: Fri, 1 Oct 2021 17:10:57 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33998"; mail-complaints-to="usenet@ciao.gmane.io" To: 50946@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 01 19:26:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWMIZ-0008ab-3n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Oct 2021 19:26:15 +0200 Original-Received: from localhost ([::1]:54362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWMIX-0002ZQ-US for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Oct 2021 13:26:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWM4q-0004bF-MW for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 13:12:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWM4o-00050Z-I5 for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 13:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWM4o-0003xe-Dt for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 13:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Oct 2021 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50946 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163310827015150 (code B ref -1); Fri, 01 Oct 2021 17:12:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Oct 2021 17:11:10 +0000 Original-Received: from localhost ([127.0.0.1]:57270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWM3y-0003wH-G9 for submit@debbugs.gnu.org; Fri, 01 Oct 2021 13:11:10 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWM3v-0003w9-QL for submit@debbugs.gnu.org; Fri, 01 Oct 2021 13:11:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWM3v-0003sp-LT for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 13:11:07 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:11699 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mWM3p-000478-0Q for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 13:11:07 -0400 Original-Received: (qmail 28978 invoked by uid 3782); 1 Oct 2021 17:10:58 -0000 Original-Received: from acm.muc.de (p4fe15cf0.dip0.t-ipconnect.de [79.225.92.240]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 01 Oct 2021 19:10:57 +0200 Original-Received: (qmail 7576 invoked by uid 1000); 1 Oct 2021 17:10:57 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_05=-0.5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216068 Archived-At: Hello, Emacs. In emacs -Q in the emacs-28 branch, create the following two line file, foobar.el, and try to load it: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; (defvar foo-baz "foobar-baz") FOOBARELISP-SHORTHANDS: (("foo" . "foobar"))) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; This will throw an error, but that isn't important. What is important is that the symbol foobar-baz is created by the elisp-shorthands facility. This shouldn't happen since: 1/- There is no Local Variables section. 2/- There is no variable elisp-shorthands in that non-existent section. The following errors are evident in hack-elisp-shorthands: 1/- The code doesn't check for a correctly formatted Local Variables section. 2/- The code, even if it did check, would only check the last 3000 bytes in the file. The section can occur anywhere in the last 3000 CHARACTERS. 3/- The code doesn't do a case-sensitive search for "elisp-shorthands". 4/- The code doesn't check for "elisp-shorthands" being a complete symbol. 5/- The code doesn't even check that "elisp-shorthands" is in a comment. I would suggest that these errors be corrected. I would also suggest that the entire code and documentation for this new facility be carefully reviewed by somebody who isn't the original author. -- Alan Mackenzie (Nuremberg, Germany).