On Fri, Sep 17, 2021 at 06:26:54PM +0100, Alan Third wrote:
> On Tue, Sep 14, 2021 at 03:35:57PM +0100, Alan Third wrote:
> > On Tue, Sep 14, 2021 at 04:17:15PM +0200, Kirill A. Korinsky wrote:
> > > Hey,
> > > 
> > > I can't broke the nuclear option anymore.
> > > 
> > > Seems it fixing everything.
> > 
> > Thanks, I'll push it to master.
> 
> This last patch breaks toolbar display on my Mac.
> 
> I think probably the best option is to change the toolbar handling so
> it actually just removes the toolbar when we don't want to display it.
> I really don't understand why the NS port goes to great lengths to
> hide it. If we remove it then it can never be displayed when it
> shouldn't be, and if it's attached to the window then it should always
> be displayed, so we don't have to concern ourselves with making sure
> the settings match after the window is resized or whatever.

Can you please try the attached patch and check that the toolbar is
behaving as expected.

It seems to work correctly here everywhere (except in GNUstep we
sometimes get an extra tall toolbar, but I doubt anyone cares too much
about that), but I think it may have removed the animation when the
toolbar is attached to the frame.

If anyone is really upset about the animation (and I'm not even sure
it IS gone) then we probably just need to create the toolbar as
invisible and attach it then mark it visible, but only do that on
Cocoa as it breaks the toolbar on frame creation in GNUstep.
-- 
Alan Third