From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS Date: Fri, 17 Sep 2021 18:26:54 +0100 Message-ID: References: <16F124DC-AFCD-41D6-B039-CB1BD715FBFE@korins.ky> <34066D3F-0684-43B4-9460-44EC98806E28@korins.ky> <8F5214BE-6F8B-46EE-9E02-537226186EE9@korins.ky> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13156"; mail-complaints-to="usenet@ciao.gmane.io" To: "Kirill A. Korinsky" , 50534@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 17 19:28:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRHel-0003A4-LZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Sep 2021 19:28:11 +0200 Original-Received: from localhost ([::1]:55578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRHej-0007Ni-TG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Sep 2021 13:28:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRHec-0007NM-5F for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 13:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRHeb-0006nQ-Tx for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 13:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRHeb-00089M-N0 for bug-gnu-emacs@gnu.org; Fri, 17 Sep 2021 13:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Sep 2021 17:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50534 X-GNU-PR-Package: emacs Original-Received: via spool by 50534-submit@debbugs.gnu.org id=B50534.163189963031271 (code B ref 50534); Fri, 17 Sep 2021 17:28:01 +0000 Original-Received: (at 50534) by debbugs.gnu.org; 17 Sep 2021 17:27:10 +0000 Original-Received: from localhost ([127.0.0.1]:32917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRHdj-00088F-AA for submit@debbugs.gnu.org; Fri, 17 Sep 2021 13:27:10 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:47913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRHdf-00087j-6T for 50534@debbugs.gnu.org; Fri, 17 Sep 2021 13:27:06 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 39DCA54; Fri, 17 Sep 2021 17:26:56 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1631899615; bh=x6URbAigpdKx+RDXeJD+NWhaWvlb7L3J2dnJ8jSZ2ps=; h=Date:From:To:Subject:References:In-Reply-To:From; b=ShIfEAwAWZmbMv/SJ/o+FKBDT1oF9+sFxmjgok044QkwjhgetrcXKsCw0MSf/Waz4 j4qBlJzwKmDaeo+DgiIgSGe3p8C+Me/+tCevA3SKpR3FLJphouogNp6e/GoiUqCEDZ kJSCeDF1GH+zjzjxTm3+iC5GgSUQDoo/62FkUvjHqft6tMIuoArqYlM542yuYtxmrn UptP88F+sgScc3QxQWi12lEVrV86muVMm+6lKEKh2n1CGga7sGWlSJXkrn0MfD+Pp1 GL1RTFaO1uu9uAc5C8M45vpt2Tove6YDxq47cKpHJCn6ikWDfUTu+B+GQOeroIhnQd fXOUm4q9mMSXQ== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1mRHdW-00021x-94; Fri, 17 Sep 2021 18:26:54 +0100 Mail-Followup-To: Alan Third , "Kirill A. Korinsky" , 50534@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214572 Archived-At: On Tue, Sep 14, 2021 at 03:35:57PM +0100, Alan Third wrote: > On Tue, Sep 14, 2021 at 04:17:15PM +0200, Kirill A. Korinsky wrote: > > Hey, > > > > I can't broke the nuclear option anymore. > > > > Seems it fixing everything. > > Thanks, I'll push it to master. This last patch breaks toolbar display on my Mac. I think probably the best option is to change the toolbar handling so it actually just removes the toolbar when we don't want to display it. I really don't understand why the NS port goes to great lengths to hide it. If we remove it then it can never be displayed when it shouldn't be, and if it's attached to the window then it should always be displayed, so we don't have to concern ourselves with making sure the settings match after the window is resized or whatever. -- Alan Third