From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Jim Porter <jporterbugs@gmail.com>,
Lars Ingebrigtsen <larsi@gnus.org>,
50538@debbugs.gnu.org
Subject: bug#50538: [PATCH] 28.0.50; electric-pair-mode fails to pair double quotes in some cases in CC mode
Date: Thu, 16 Sep 2021 18:26:36 +0000 [thread overview]
Message-ID: <YUOMXG7i2E9FhAqa@ACM> (raw)
In-Reply-To: <83k0jh9jn6.fsf@gnu.org>
Hello, Eli.
On Thu, Sep 16, 2021 at 08:25:33 +0300, Eli Zaretskii wrote:
> > From: Jim Porter <jporterbugs@gmail.com>
> > Cc: 50538@debbugs.gnu.org
> > Date: Wed, 15 Sep 2021 15:17:23 -0700
> > On 9/11/2021 8:58 PM, Jim Porter wrote:
> > > (Note: I've just updated my copyright assignment information, but
> > > haven't received confirmation that everything is in order, so this might
> > > need to wait until that's done for it to merge.)
> > I've gotten confirmation that my copyright assignment info is all
> > up-to-date, so once this patch passes muster, it should be ok to merge it.
> Your copyright assignment is on file, so we are good in that
> department.
> > On 9/12/2021 11:05 AM, Jim Porter wrote:
> > > Note however that this solution isn't perfect: it means a user's custom
> > > `electric-pair-inhibit-predicate' can only inhibit *more* than CC mode's
> > > default behavior, not less. I think that's a reasonable compromise
> > > though, and users who want more direct control can set
> > > `electric-pair-inhibit-predicate' inside `c-mode-common-hook'. A
> > > "perfect" solution here would probably require adding new customization
> > > points to `electric-pair-mode' (e.g. a way for major modes to override
> > > how the syntax is analyzed), and I'm not sure the added complexity would
> > > be worth it, especially since this code is already a bit tricky.
> > I'm not sure if someone has a better idea for how to do things, but for
> > my config[1], the patch works well and makes CC modes behave the same as
> > other programming modes. In my opinion, the worst thing
> > `electric-pair-mode' can do is to behave inconsistently, since that
> > forces the user to pay close attention to something that should be
> > almost invisible/automatic.
> I don't use this minor mode, so I don't think my opinion on this
> matters much. I will defer to Lars and Alan here.
Thanks, I've downloaded the bug thread from debbugs, and I'll look at
it. I don't actually use the minor mode either, but the patch is to do
with C++ Mode.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2021-09-16 18:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 3:58 bug#50538: [PATCH] 28.0.50; electric-pair-mode fails to pair double quotes in some cases in CC mode Jim Porter
2021-09-12 6:26 ` Eli Zaretskii
2021-09-12 18:05 ` Jim Porter
2021-09-15 22:17 ` Jim Porter
2021-09-16 5:25 ` Eli Zaretskii
2021-09-16 12:40 ` Lars Ingebrigtsen
2021-09-16 12:59 ` Dmitry Gutov
2021-09-16 13:17 ` Lars Ingebrigtsen
2021-09-16 17:04 ` João Távora
2021-09-16 17:11 ` Eli Zaretskii
2021-09-16 17:33 ` João Távora
2021-09-16 17:29 ` Jim Porter
2021-09-16 19:05 ` Alan Mackenzie
2021-09-16 20:51 ` João Távora
2021-09-17 18:12 ` Alan Mackenzie
2021-09-16 18:26 ` Alan Mackenzie [this message]
2021-09-16 20:49 ` Alan Mackenzie
2021-09-16 21:36 ` Jim Porter
2021-09-17 17:08 ` Alan Mackenzie
2021-09-23 2:01 ` bug#50538: [PATCH v3] " Jim Porter
2021-09-26 20:58 ` Alan Mackenzie
2021-09-28 4:57 ` bug#50538: [PATCH v4] " Jim Porter
2021-10-03 17:58 ` bug#50538: [PATCH v5] " Jim Porter
2021-11-06 0:22 ` bug#50538: [PATCH] " Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUOMXG7i2E9FhAqa@ACM \
--to=acm@muc.de \
--cc=50538@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).