From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#50160: 28.0.50; Wrong NSToolbarItem identifier Date: Thu, 9 Sep 2021 21:59:28 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19509"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50160@debbugs.gnu.org To: tsuucat Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 09 23:00:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOR9s-0004po-Je for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Sep 2021 23:00:32 +0200 Original-Received: from localhost ([::1]:42682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOR9r-0001Dt-Gn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Sep 2021 17:00:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOR9U-0001Db-L0 for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 17:00:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOR9N-0004vt-V0 for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 17:00:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOR9N-000876-Px for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 17:00:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Sep 2021 21:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50160 X-GNU-PR-Package: emacs Original-Received: via spool by 50160-submit@debbugs.gnu.org id=B50160.163122118231142 (code B ref 50160); Thu, 09 Sep 2021 21:00:01 +0000 Original-Received: (at 50160) by debbugs.gnu.org; 9 Sep 2021 20:59:42 +0000 Original-Received: from localhost ([127.0.0.1]:36349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOR94-00086E-JJ for submit@debbugs.gnu.org; Thu, 09 Sep 2021 16:59:42 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:48601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOR92-00085x-0X for 50160@debbugs.gnu.org; Thu, 09 Sep 2021 16:59:41 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 5910F4F; Thu, 9 Sep 2021 20:59:33 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1631221172; bh=aQn/gAJMrunWbJebPszj7cXLDNBUSb0Jk05AqjuuJyI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZcAOIqRWsG16SbvlGr7GW2pvdQgUnU81b9/LPOqWkc84XObcIfHGLdo0gXTdY5+jA qTnimCmLRaHIJcnUSCzuVbHaww9aMvCDt5AzCrcPrCs67Hga/i7aoPrMRxqOM31Mv0 j9N0k3ryRN3JE4yA1p7lFJdOsBKlgutPhuj1MrHbKKyVqJLMgH0JLtLNGBioTDPukv dPl0VNG5XyqcrfeiIgKr6K62QP6X+covh3BBL7HWDbDqu0FRFXLHJKvyYfeuCYQDrd Otj140mR8yRNuiZV6YtN1iY2Lrgu85REhsi7zwDfgKbczaTt0pOCbs9P+rUGgIe8fu gqy5deRysHkZw== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1mOR8q-001Tc7-Sn; Thu, 09 Sep 2021 21:59:28 +0100 Mail-Followup-To: Alan Third , tsuucat , 50160@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213947 Archived-At: On Fri, Sep 10, 2021 at 02:33:40AM +0900, tsuucat wrote: > > > Ah, hmm... Perhaps we should append the label text to the hash or > > something? > > I tried to append the label text to the hash. Most items fixed. But > isearch.el uses “undo” icon and “Undo” label for isearch-delete-char item > so the tool-tip is wrong… > It is hard to set correct identifier because anyone can create toolbar items > dynamically in Emacs lisp. > > I noticed the current toolbaritem problem only matters label and tool-tip. > Executed commands are not wrong. I suppose we could concatenate the hashes of all the values that might matter. Alternatively maybe we just don't cache the toolbar items? I don't know if that's worth investigating. My experience with some other areas of the NS port is that there's a lot of caching and things going on that doesn't seem to actually save us anything, but the toolbar can be refreshed very often in the right circumstances, so it may be best to keep the cache. -- Alan Third