From 17c5fbeca65de70e471a532ced3aead96468eaef Mon Sep 17 00:00:00 2001 From: Alan Third Date: Mon, 13 Sep 2021 20:09:22 +0100 Subject: [PATCH v3] Fix incorrectly appearing toolbar on NS (bug#50534) * src/nsmenu.m (update_frame_tool_bar): Ensure both sides of the test are booleans. --- src/nsmenu.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nsmenu.m b/src/nsmenu.m index 0d0b2f60c9..947c8368ed 100644 --- a/src/nsmenu.m +++ b/src/nsmenu.m @@ -1090,7 +1090,7 @@ - (void)menu:(NSMenu *)menu willHighlightItem:(NSMenuItem *)item #undef TOOLPROP } - if ([toolbar isVisible] != FRAME_EXTERNAL_TOOL_BAR (f)) + if (![toolbar isVisible] != !FRAME_EXTERNAL_TOOL_BAR (f)) { f->output_data.ns->in_animation = 1; [toolbar setVisible: FRAME_EXTERNAL_TOOL_BAR (f)]; -- 2.30.2