From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#48994: 28.0.50; [PATCH] 28.0.50; Native compilation unnecessarily recompiles .eln (macOS) Date: Sat, 26 Jun 2021 10:38:19 +0100 Message-ID: References: <83fsxh1wdd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40047"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48994-done@debbugs.gnu.org To: Matthew Bauer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 26 11:39:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lx4n8-000AAh-1A for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Jun 2021 11:39:58 +0200 Original-Received: from localhost ([::1]:48474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lx4n7-0004OT-3W for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Jun 2021 05:39:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lx4mE-0003LH-Gp for bug-gnu-emacs@gnu.org; Sat, 26 Jun 2021 05:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lx4mE-0001aS-46 for bug-gnu-emacs@gnu.org; Sat, 26 Jun 2021 05:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lx4mD-0002WE-UB for bug-gnu-emacs@gnu.org; Sat, 26 Jun 2021 05:39:01 -0400 Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Jun 2021 09:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 48994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48994-done@debbugs.gnu.org id=D48994.16247003159639 (code D ref 48994); Sat, 26 Jun 2021 09:39:01 +0000 Original-Received: (at 48994-done) by debbugs.gnu.org; 26 Jun 2021 09:38:35 +0000 Original-Received: from localhost ([127.0.0.1]:47135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lx4lm-0002VM-PO for submit@debbugs.gnu.org; Sat, 26 Jun 2021 05:38:35 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:48133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lx4li-0002V2-Ak for 48994-done@debbugs.gnu.org; Sat, 26 Jun 2021 05:38:33 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 06412937; Sat, 26 Jun 2021 09:38:23 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1624700302; bh=wfubJcBWJYOygLkwivsaBb3lE7K2lrpnOV916+w/h5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aT348SQH652wi69bHb+9eFucIBRBogRT6Hz7NwsCGai5GEsAqy7rTwtju9uUAHNUG FWRqzZiVqPrOGKWr/L6FqANEBfx/joAml/Jtfq2a1lE5qR7j5wpRHB3rfStKsnphlo SCP9yCiJFLHob4NCfyJHmrhBTZCxMXvusyT2o76WBE33xY5buzq90OdAaR1vLOXcrn yBA4mCcdrXfs/hBwRZdvbNgdMJuc0BOnnRuNITnZavLkZn06wP/01qYxEvni45/Gaz TuRoq2vsSJISTB7XGWod4ygJcJnmxCVQfbZcqU2AKSy7BPvoX5rRu+4LuK1PqlrCqI xf+jXrmS917/A== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1lx4lX-001Nd2-Sk; Sat, 26 Jun 2021 10:38:19 +0100 Mail-Followup-To: Alan Third , Matthew Bauer , 48994-done@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209009 Archived-At: I've pushed it to master. Thanks! On Wed, Jun 23, 2021 at 03:46:12PM -0500, Matthew Bauer wrote: > That works for me! No apparent issues. > > On Wed, Jun 23, 2021 at 10:59 AM Alan Third wrote: > > > On Tue, Jun 22, 2021 at 06:01:25PM -0500, Matthew Bauer wrote: > > > > Turns out there's another variable that should only be set when > > > > building the app. > > > > > > > Please try the attached patch. > > > > > > That works for me ! > > > > > > So previously the nextstep/Emacs.app was getting generated even > > > with --disable-ns-self-contained. I think that's fine to not build in > > > this case - in fact it duplicates the Emacs executable - but just a note > > > that it kind of changes things for packages. I have a fix for Nixpkgs > > > (which previously installed nexstep/Emacs.app), but I think > > > homebrew-emacs-plus would also be effected: > > > > > > https://github.com/d12frosted/homebrew-emacs-plus > > > > This sounds like madness to me, but I see it's a supported > > configuration mentioned in our install files. > > > > So, attempt three attached! > > -- Alan Third