From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#48994: 28.0.50; [PATCH] 28.0.50; Native compilation unnecessarily recompiles .eln (macOS) Date: Wed, 23 Jun 2021 21:48:11 +0100 Message-ID: References: <83fsxh1wdd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16893"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48994@debbugs.gnu.org To: Matthew Bauer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 23 22:49:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw9o8-00048R-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Jun 2021 22:49:14 +0200 Original-Received: from localhost ([::1]:50352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lw9o7-0000qT-4U for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Jun 2021 16:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw9ny-0000qH-5X for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2021 16:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lw9nx-0002OJ-UD for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2021 16:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lw9nx-0005Fk-TW for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2021 16:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jun 2021 20:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48994-submit@debbugs.gnu.org id=B48994.162448130220142 (code B ref 48994); Wed, 23 Jun 2021 20:49:01 +0000 Original-Received: (at 48994) by debbugs.gnu.org; 23 Jun 2021 20:48:22 +0000 Original-Received: from localhost ([127.0.0.1]:41916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lw9nK-0005En-7f for submit@debbugs.gnu.org; Wed, 23 Jun 2021 16:48:22 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:48809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lw9nI-0005EY-H9 for 48994@debbugs.gnu.org; Wed, 23 Jun 2021 16:48:21 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 42E9E955; Wed, 23 Jun 2021 20:48:14 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1624481293; bh=1eLu+x0oTEDuovrSO+my7OAe3eINpMfMelpPEu2Eisg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LxTSz1BhYCIqsFzjUSoM4K07N4SoQvhnftTrOFt4imYaxObQTk/MkW+fSAQGuk526 XXDiF5idIxz4VOKLKYe7ZC/zD698mzD/bOatfp9jXAAt/CTFpmHrir9yZoj2OCgy/K hK0WMol8AN97PPGiX6JB/G06dqzuU8AAGrotPmEcWuHbKz3rO1P5gAhVY5aP21MwSE byoFK2X4uTUPLzrKE0d2SA6J090h4E3wrGzBAWlRIsyO5I/uR+utHs90L5/xMnIDqM XU8nKx3tVoCSOW2MgdQE80+G75m+ZCXirR/TPNXQZTdI9/LC2uRwAyC2DXHt3DfIlv J6AoHExhHOqfA== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1lw9n9-001FsW-92; Wed, 23 Jun 2021 21:48:11 +0100 Mail-Followup-To: Alan Third , Matthew Bauer , 48994@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208914 Archived-At: Thanks! I'll leave it a few days before pushing it just in case anyone else spots anything wrong with it. On Wed, Jun 23, 2021 at 03:46:12PM -0500, Matthew Bauer wrote: > That works for me! No apparent issues. > > On Wed, Jun 23, 2021 at 10:59 AM Alan Third wrote: > > > On Tue, Jun 22, 2021 at 06:01:25PM -0500, Matthew Bauer wrote: > > > > Turns out there's another variable that should only be set when > > > > building the app. > > > > > > > Please try the attached patch. > > > > > > That works for me ! > > > > > > So previously the nextstep/Emacs.app was getting generated even > > > with --disable-ns-self-contained. I think that's fine to not build in > > > this case - in fact it duplicates the Emacs executable - but just a note > > > that it kind of changes things for packages. I have a fix for Nixpkgs > > > (which previously installed nexstep/Emacs.app), but I think > > > homebrew-emacs-plus would also be effected: > > > > > > https://github.com/d12frosted/homebrew-emacs-plus > > > > This sounds like madness to me, but I see it's a supported > > configuration mentioned in our install files. > > > > So, attempt three attached! > > -- Alan Third