From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems Date: Wed, 9 Jun 2021 16:19:35 +0100 Message-ID: References: <51cb-60bf4900-1dd-2840bc80@23790836> <875yyoo9gy.fsf@gnus.org> <87r1hcmu2q.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15185"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48902@debbugs.gnu.org, Lars Ingebrigtsen , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , naofumi@yasufuku.dev To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 09 17:31:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lr0B5-0003cT-MV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 17:31:35 +0200 Original-Received: from localhost ([::1]:60984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lr0B4-0001ds-Np for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 11:31:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqzzw-0000H2-Bv for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 11:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqzzu-0001oM-Ft for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 11:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqzzu-0008KJ-4G for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 11:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jun 2021 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48902 X-GNU-PR-Package: emacs Original-Received: via spool by 48902-submit@debbugs.gnu.org id=B48902.162325199131978 (code B ref 48902); Wed, 09 Jun 2021 15:20:02 +0000 Original-Received: (at 48902) by debbugs.gnu.org; 9 Jun 2021 15:19:51 +0000 Original-Received: from localhost ([127.0.0.1]:34422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqzzi-0008Ji-OQ for submit@debbugs.gnu.org; Wed, 09 Jun 2021 11:19:50 -0400 Original-Received: from outbound.soverin.net ([116.202.65.218]:39585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqzzf-0008JN-KG for 48902@debbugs.gnu.org; Wed, 09 Jun 2021 11:19:49 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 3E26F6094F; Wed, 9 Jun 2021 15:19:41 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1623251980; bh=3ZiAckX3X7Qbt6DqvnRJKNwkr4OodP1whsZWzES/1y4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yj8CxfbtSZWP90aRlEw61tgoFclHEpJF78H/7/dFfNo+gfFNUkFVY/7nvtU1+mOnR 2D2xUOHvUqjAV0Wsso5fkI5g3HQYJIakhBVo0IfLvUR0kvZNKVtcydakX9jtlQvlL0 /fzFCT2RN7osP1SiMy/TnVYIC5Ub8BQsY+PviorqvTvM/ljqPbBZvEgTb1KoHljUbd e1GZTgmmkADmWZ6Vt6NdEjEqPp17JeIEfyLjMux1HdWY2p+Pmd3Mtvq9R+ay+csflF 7Zwh29xsaaWqINOiPagB9GjoTXf61Yt0CLKa6sc0+k/eB8YNzKQ5YZXlAc3/2O1svC ORWN3oAGTkmXw== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1lqzzT-001PUk-8z; Wed, 09 Jun 2021 16:19:35 +0100 Mail-Followup-To: Alan Third , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Lars Ingebrigtsen , naofumi@yasufuku.dev, 48902@debbugs.gnu.org, Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208298 Archived-At: On Wed, Jun 09, 2021 at 01:40:18PM +0200, Mattias Engdegård wrote: > 8 juni 2021 kl. 22.33 skrev Alan Third : > > > Patch attached. I've tested it here but I only have a couple of images > > to try it with. > > Looks fine, but the image_find_image_file comment needs to be > amended since it says that it returns an encoded string. I've made a change to the comment. > Furthermore, if we use stringWithLispString: for file names, no > special file name encoding step should be needed on our side, since > the NS libs will perform any needed normalisation (at least if I've > understood it right). Yes, I believe that's right, so I've made that change too and pushed to master. As far as I can see this fixes the problem so I'll close the bug report. If it's still broken in some way, please reply to this email and we'll reopen the bug. Thanks everyone! -- Alan Third