From: Alan Third <alan@idiocy.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 48902@debbugs.gnu.org, "Lars Ingebrigtsen" <larsi@gnus.org>,
"Rudolf Adamkovič" <salutis@me.com>,
naofumi@yasufuku.dev
Subject: bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems
Date: Wed, 9 Jun 2021 16:19:35 +0100 [thread overview]
Message-ID: <YMDcBxGFgbrE2vOv@idiocy.org> (raw)
In-Reply-To: <DB149BE5-05BC-4D59-BD84-480B3AD6D10A@acm.org>
On Wed, Jun 09, 2021 at 01:40:18PM +0200, Mattias Engdegård wrote:
> 8 juni 2021 kl. 22.33 skrev Alan Third <alan@idiocy.org>:
>
> > Patch attached. I've tested it here but I only have a couple of images
> > to try it with.
>
> Looks fine, but the image_find_image_file comment needs to be
> amended since it says that it returns an encoded string.
I've made a change to the comment.
> Furthermore, if we use stringWithLispString: for file names, no
> special file name encoding step should be needed on our side, since
> the NS libs will perform any needed normalisation (at least if I've
> understood it right).
Yes, I believe that's right, so I've made that change too and pushed
to master.
As far as I can see this fixes the problem so I'll close the bug
report. If it's still broken in some way, please reply to this email
and we'll reopen the bug.
Thanks everyone!
--
Alan Third
next prev parent reply other threads:[~2021-06-09 15:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 13:32 bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-07 14:08 ` Lars Ingebrigtsen
2021-06-07 14:15 ` Eli Zaretskii
2021-06-07 14:24 ` Lars Ingebrigtsen
2021-06-07 14:36 ` Eli Zaretskii
2021-06-07 14:13 ` Eli Zaretskii
2021-06-08 22:21 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-08 10:39 ` naofumi
2021-06-08 11:57 ` Lars Ingebrigtsen
2021-06-08 12:12 ` Alan Third
2021-06-08 12:14 ` Lars Ingebrigtsen
2021-06-08 17:45 ` Mattias Engdegård
2021-06-08 18:18 ` Eli Zaretskii
2021-06-08 19:13 ` naofumi
2021-06-08 20:08 ` Mattias Engdegård
2021-06-08 19:10 ` Alan Third
2021-06-08 19:52 ` Mattias Engdegård
2021-06-08 20:33 ` Alan Third
2021-06-09 11:40 ` Mattias Engdegård
2021-06-09 15:19 ` Alan Third [this message]
2021-06-11 22:09 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-09 11:56 ` Eli Zaretskii
2021-06-08 18:17 ` Mattias Engdegård
2021-06-08 12:37 ` Eli Zaretskii
2021-06-08 13:00 ` Alan Third
2021-06-08 14:02 ` Eli Zaretskii
2021-06-08 16:19 ` Alan Third
2021-06-08 18:09 ` Eli Zaretskii
2021-06-08 19:24 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMDcBxGFgbrE2vOv@idiocy.org \
--to=alan@idiocy.org \
--cc=48902@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
--cc=naofumi@yasufuku.dev \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).