From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#48406: 28.0.50; Emacs stuck in infinite loop in wait_reading_process_output when opening in fullscreen (NS) Date: Wed, 26 May 2021 21:26:39 +0100 Message-ID: References: <5E1B46C6-1359-4CCF-B4EF-5527FB915F93@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3541"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Illia Ostapyshyn , 48406@debbugs.gnu.org To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 26 22:38:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm0I3-0000mL-Om for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 May 2021 22:38:07 +0200 Original-Received: from localhost ([::1]:39682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lm0I2-0005qT-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 May 2021 16:38:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lm07K-0004Fp-So for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 16:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lm07K-0003zC-K6 for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 16:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lm07K-0002jp-EH for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 16:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 May 2021 20:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48406 X-GNU-PR-Package: emacs Original-Received: via spool by 48406-submit@debbugs.gnu.org id=B48406.162206081310506 (code B ref 48406); Wed, 26 May 2021 20:27:02 +0000 Original-Received: (at 48406) by debbugs.gnu.org; 26 May 2021 20:26:53 +0000 Original-Received: from localhost ([127.0.0.1]:49992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm07A-0002jO-Kq for submit@debbugs.gnu.org; Wed, 26 May 2021 16:26:52 -0400 Original-Received: from outbound.soverin.net ([116.202.65.218]:33439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm078-0002jA-4u for 48406@debbugs.gnu.org; Wed, 26 May 2021 16:26:51 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 7592F609D7 for <48406@debbugs.gnu.org>; Wed, 26 May 2021 20:26:43 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1622060802; bh=uqlK/o2cvpqkTflL1Y36e3p+tfqJa/+BvGETL+NGQbo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S48I58+mmBzFIZRl40wW20pv18M9QjTqI3sqthox9QoOxoalZ/6zvYp/4Cq+uuTnE UoxUb2DYjJmEpa9u5mhpKYtTgpTH75iAxCP8PqN7dCI5wLvpFzz4CF21j4162vp9r3 1KBC5EYzWay7S4rQtwU6kFA7Pyu71FY3bH5CWKsTGOGkGhwkmZELlFNvPJupKASU3z ZucYFUpLc6b4Q3ogkNzw1wHglMlb6+dOyqnexz2xgd+SXi5knYnwRTlEVsR4774Aeu 7tIawjcnqWs1T5y32Zuj40UFXdPMvDDOFGAysAlc+BzNjwOymDbucDHLJP7NdwXLyO DvOKthwoT8ckQ== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1lm06x-000GLR-Dd; Wed, 26 May 2021 21:26:39 +0100 Mail-Followup-To: Alan Third , Andrii Kolomoiets , Illia Ostapyshyn , 48406@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207317 Archived-At: On Sun, May 16, 2021 at 11:09:39PM +0300, Andrii Kolomoiets wrote: > Alan Third writes: > > > You know, I'm probably being stupid, but I can't for the life of me > > remember why we need to wait for the fullscreen transition to > > complete. I *thought* it was because we had a crash if we didn't, but > > if I remove the wait it all works just fine... > > Same here. The code snippets provided in Bug#28496 and Bug#36672 are > works fine. I'm really inclined to try removing it and seeing if anyone complains. I don't think they will. > > or that the older drawing scheme used before 10.14 has a problem and > > the new one doesn't... Or something else. Do you have any idea? > > This is the only example that comes to my mind for now: > > (progn > (toggle-frame-fullscreen) > (toggle-frame-fullscreen)) > > Though code like this is not widely used (hope so), it's still some kind > of unexpected behavior. Hah, I was expecting it to crash, but it's very well behaved! :) I guess we could check whether we're already in a fullscreen transition, and if so schedule another call to happen later on... I'm not sure if it's really necessary though. > > I *do* remember that there was a pause required for the non-native > > fullscreen due to a crash, and I don't think that will have changed, > > except that I don't think I've heard from anyone still using 10.6 for > > a couple of years now. > > Well, we can pause for the non-native fullscreen users. Good news, as far as I can see the pause is no longer required! It's in ns_fullscreen_hook, so if you remove that and all the other pauses too, we can try pushing it up to master. (See bug#28443.) -- Alan Third