From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#48337: Fwd: 28.0.50; Emacs crashing randomly (possibly minibuffer activity related) Date: Tue, 11 May 2021 20:14:47 +0000 Message-ID: References: <87tunasd2u.fsf@linaro.org> <83fsyu57oj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14325"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48337@debbugs.gnu.org To: Alex =?UTF-8?Q?Benn=C3=A9e?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 11 22:15:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgYmd-0003cF-Kn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 22:15:11 +0200 Original-Received: from localhost ([::1]:43456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgYmc-0001vh-G0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 16:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgYmU-0001vU-NH for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 16:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgYmU-0004am-GQ for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 16:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgYmU-0002o4-CD for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 16:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2021 20:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48337 X-GNU-PR-Package: emacs Original-Received: via spool by 48337-submit@debbugs.gnu.org id=B48337.162076409510757 (code B ref 48337); Tue, 11 May 2021 20:15:02 +0000 Original-Received: (at 48337) by debbugs.gnu.org; 11 May 2021 20:14:55 +0000 Original-Received: from localhost ([127.0.0.1]:37579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgYmN-0002nR-HJ for submit@debbugs.gnu.org; Tue, 11 May 2021 16:14:55 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:50671 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lgYmM-0002nE-1m for 48337@debbugs.gnu.org; Tue, 11 May 2021 16:14:54 -0400 Original-Received: (qmail 58763 invoked by uid 3782); 11 May 2021 20:14:48 -0000 Original-Received: from acm.muc.de (p4fe15d8c.dip0.t-ipconnect.de [79.225.93.140]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 11 May 2021 22:14:47 +0200 Original-Received: (qmail 13084 invoked by uid 1000); 11 May 2021 20:14:47 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206290 Archived-At: Hello, Alex. On Tue, May 11, 2021 at 07:51:20 +0100, Alex Bennée wrote: > I can now recreate at will with a magit sequence (l o hackbox/ TAB) which > triggers a minibuffer re-size to accommodate the list of git branches: Could you possibly give us a precise recipe to reproduce this bug, and a GDB backtrace with Emacs compiled with CFLAGS='-O0 g3' (or similar)? So much of the needed information in your large dump post has been optimised away by the compiler. Would you please also make sure that the Lisp backtrace is at the end of the GDB backtrace. I think this should happen automatically if you have an Emacs .gdbinit in the directory where you start GDB from. That Factive_minibuffer_window is throwing an error is mainly because it is being invalidly called. In particular, the variable minibuf_level appears to be invalid, as compared with the internal list of minibuffers. Would you please also test my theory of the last paragraph, by applying the following patch (which reverses Eli's recent patch) and seeing if the bug still happens. Thanks! diff --git a/src/minibuf.c b/src/minibuf.c index 52d1275451..3afba0db68 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -653,6 +653,7 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, } minibuf_level++; /* Before calling choose_minibuf_frame. */ + minibuffer = get_minibuffer (minibuf_level); /* Temporary fix, 2021-05-11. */ /* Choose the minibuffer window and frame, and take action on them. */ @@ -766,7 +767,8 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, /* Switch to the minibuffer. */ - minibuffer = get_minibuffer (minibuf_level); + /* minibuffer = get_minibuffer (minibuf_level); Temporarily moved, + 2021-05-11. */ set_minibuffer_mode (minibuffer, minibuf_level); Fset_buffer (minibuffer); @@ -969,8 +971,8 @@ is_minibuffer (EMACS_INT depth, Lisp_Object buf) nth_minibuffer (EMACS_INT depth) { Lisp_Object tail = Fnthcdr (make_fixnum (depth), Vminibuffer_list); - if (NILP (tail)) - return Qnil; + /* if (NILP (tail)) Temporarily commented out, 2021-05-11 + return Qnil; */ return XCAR (tail); } [ .... ] > Let me know if you want something else. See above. ;-) [ .... ] > On Tue, 11 May 2021 at 03:24, Eli Zaretskii wrote: > > Please show the Lisp value of Vminibuffer_list. I have seen the answer to this request. Thanks! > -- > Alex Bennée > KVM/QEMU Hacker for Linaro -- Alan Mackenzie (Nuremberg, Germany).