From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#47766: 28.0.50; choose-completion fails Date: Thu, 6 May 2021 09:55:02 +0000 Message-ID: References: <20210422.213429.112377311480064511.enometh@meer.net> <87a6p942l9.fsf@gnus.org> <20210506.081639.1881805365026827947.enometh@meer.net> <875yzw2ref.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13528"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Madhu , stefan@marxist.se, gregory@heytings.org, 47766@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 11:56:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leajv-0003N4-0A for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 11:56:15 +0200 Original-Received: from localhost ([::1]:53008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leaju-0000Oo-2y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 05:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leajk-0000Lo-Iz for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 05:56:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leajh-0007EH-P5 for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 05:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leajh-0001bz-MG for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 05:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 09:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 47766-submit@debbugs.gnu.org id=B47766.16202949126184 (code B ref 47766); Thu, 06 May 2021 09:56:01 +0000 Original-Received: (at 47766) by debbugs.gnu.org; 6 May 2021 09:55:12 +0000 Original-Received: from localhost ([127.0.0.1]:37160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leaiu-0001bg-6j for submit@debbugs.gnu.org; Thu, 06 May 2021 05:55:12 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:20615 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1leais-0001bU-GI for 47766@debbugs.gnu.org; Thu, 06 May 2021 05:55:11 -0400 Original-Received: (qmail 44035 invoked by uid 3782); 6 May 2021 09:55:03 -0000 Original-Received: from acm.muc.de (p4fe15eae.dip0.t-ipconnect.de [79.225.94.174]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 06 May 2021 11:55:03 +0200 Original-Received: (qmail 8566 invoked by uid 1000); 6 May 2021 09:55:02 -0000 Content-Disposition: inline In-Reply-To: <875yzw2ref.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205791 Archived-At: Hello, Lars. On Thu, May 06, 2021 at 10:33:12 +0200, Lars Ingebrigtsen wrote: > Madhu writes: > > Yes. I haven't seen any problems (though I can't claim to have tested > > all the corner cases) > OK. Alan, are you pushing the change, then? I'll commit the change, yes, soon, hopefully today. > This bit looks odd, though: > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -4119,7 +4119,7 @@ window-deletable-p > (let ((minibuf (active-minibuffer-window))) > (and minibuf (eq frame (window-frame minibuf)) > (not (eq (default-toplevel-value > - minibuffer-follows-selected-frame) > + 'minibuffer-follows-selected-frame) > t))))) Yes, I was hoping nobody would notice that. ;-) The quote is absolutely required for correct functioning. Missing the quote didn't throw an error when m-f-s-frame was t or nil (but the whole point of default-toplevel-value was lost), but did when it was 'hybrid. With the commit, the glitch will be fixed forever. > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).