From: Alan Mackenzie <acm@muc.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Madhu <enometh@meer.net>,
stefan@marxist.se, gregory@heytings.org, 47766@debbugs.gnu.org
Subject: bug#47766: 28.0.50; choose-completion fails
Date: Thu, 6 May 2021 09:55:02 +0000 [thread overview]
Message-ID: <YJO89nBcVmYarqZ/@ACM> (raw)
In-Reply-To: <875yzw2ref.fsf@gnus.org>
Hello, Lars.
On Thu, May 06, 2021 at 10:33:12 +0200, Lars Ingebrigtsen wrote:
> Madhu <enometh@meer.net> writes:
> > Yes. I haven't seen any problems (though I can't claim to have tested
> > all the corner cases)
> OK. Alan, are you pushing the change, then?
I'll commit the change, yes, soon, hopefully today.
> This bit looks odd, though:
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -4119,7 +4119,7 @@ window-deletable-p
> (let ((minibuf (active-minibuffer-window)))
> (and minibuf (eq frame (window-frame minibuf))
> (not (eq (default-toplevel-value
> - minibuffer-follows-selected-frame)
> + 'minibuffer-follows-selected-frame)
> t)))))
Yes, I was hoping nobody would notice that. ;-) The quote is
absolutely required for correct functioning. Missing the quote didn't
throw an error when m-f-s-frame was t or nil (but the whole point of
default-toplevel-value was lost), but did when it was 'hybrid. With the
commit, the glitch will be fixed forever.
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2021-05-06 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 5:03 bug#47766: 28.0.50; choose-completion fails Madhu
2021-04-14 8:43 ` Gregory Heytings
2021-04-20 13:25 ` Stefan Kangas
2021-04-21 13:54 ` Alan Mackenzie
2021-04-22 15:07 ` Alan Mackenzie
2021-04-22 16:04 ` Madhu
2021-05-05 15:33 ` Lars Ingebrigtsen
2021-05-06 2:46 ` Madhu
2021-05-06 8:33 ` Lars Ingebrigtsen
2021-05-06 9:55 ` Alan Mackenzie [this message]
2021-05-06 10:59 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJO89nBcVmYarqZ/@ACM \
--to=acm@muc.de \
--cc=47766@debbugs.gnu.org \
--cc=enometh@meer.net \
--cc=gregory@heytings.org \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).