From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped. Date: Thu, 13 May 2021 14:51:18 +0000 Message-ID: References: <20201122170830.GD5912@ACM> <20201122181957.GF5912@ACM> <73ccc858-dd03-248f-4b89-5679a8f3cd63@yandex.ru> <20201122211353.GH5912@ACM> <00dc580c-3b48-c185-9020-2cb2b7528884@yandex.ru> <20201122220110.GI5912@ACM> <87eeearkae.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38816"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43558@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier , Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 13 16:52:47 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhChj-0009yG-N3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 May 2021 16:52:47 +0200 Original-Received: from localhost ([::1]:43788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhChi-0002EH-N3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 May 2021 10:52:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhCh1-0002BC-S7 for bug-gnu-emacs@gnu.org; Thu, 13 May 2021 10:52:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhCh1-00038j-6n for bug-gnu-emacs@gnu.org; Thu, 13 May 2021 10:52:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhCh1-0005VZ-5f for bug-gnu-emacs@gnu.org; Thu, 13 May 2021 10:52:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 May 2021 14:52:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43558-submit@debbugs.gnu.org id=B43558.162091748921074 (code B ref 43558); Thu, 13 May 2021 14:52:03 +0000 Original-Received: (at 43558) by debbugs.gnu.org; 13 May 2021 14:51:29 +0000 Original-Received: from localhost ([127.0.0.1]:44057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhCgT-0005Tp-00 for submit@debbugs.gnu.org; Thu, 13 May 2021 10:51:29 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:61317 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lhCgP-0005TO-GY for 43558@debbugs.gnu.org; Thu, 13 May 2021 10:51:27 -0400 Original-Received: (qmail 10475 invoked by uid 3782); 13 May 2021 14:51:18 -0000 Original-Received: from acm.muc.de (p4fe15ecf.dip0.t-ipconnect.de [79.225.94.207]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 13 May 2021 16:51:18 +0200 Original-Received: (qmail 11130 invoked by uid 1000); 13 May 2021 14:51:18 -0000 Content-Disposition: inline In-Reply-To: <87eeearkae.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206445 Archived-At: Hello, Lars. On Thu, May 13, 2021 at 12:38:01 +0200, Lars Ingebrigtsen wrote: > Stefan Monnier writes: > > I do want to clarify my position, tho: while I don't like your patch > > very much because I think a Lisp-level solution (like the one I used in > > sm-c-mode) is preferable I find your patch acceptable. > This was the patch that adds the "e" syntax modifier? Apparently this > thread stalled here, and as far as I can see, the patch was never applied? That is correct, yes. The patch was working and ready, but I took Stefan's criticisms on board, and I think he was right. It was a fairly large change to syntax.c with a minor gain. Also, it would have meant having two alternative comment mechanisms in CC Mode for a few releases. So I think on balance, it would be better to regard the patch as an experiment only, which should go no further. I think the bug should stay open, though. CC Mode still doesn't handle multi-line comments absolutely correctly, and these could surely be fixed, like Stefan said, by using syntax-table text properties somehow. I also created a plethora of syntax test cases for the patch, some of which are applicable to syntax.c as is. I'll get around to sorting these out and committing them sometime. > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).