From: Alan Mackenzie <acm@muc.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43558@debbugs.gnu.org, "Mattias Engdegård" <mattiase@acm.org>,
"Stefan Monnier" <monnier@iro.umontreal.ca>,
"Dmitry Gutov" <dgutov@yandex.ru>
Subject: bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped.
Date: Thu, 13 May 2021 14:51:18 +0000 [thread overview]
Message-ID: <YJ085r9abcNUsbSd@ACM> (raw)
In-Reply-To: <87eeearkae.fsf@gnus.org>
Hello, Lars.
On Thu, May 13, 2021 at 12:38:01 +0200, Lars Ingebrigtsen wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > I do want to clarify my position, tho: while I don't like your patch
> > very much because I think a Lisp-level solution (like the one I used in
> > sm-c-mode) is preferable I find your patch acceptable.
> This was the patch that adds the "e" syntax modifier? Apparently this
> thread stalled here, and as far as I can see, the patch was never applied?
That is correct, yes. The patch was working and ready, but I took
Stefan's criticisms on board, and I think he was right. It was a fairly
large change to syntax.c with a minor gain. Also, it would have meant
having two alternative comment mechanisms in CC Mode for a few releases.
So I think on balance, it would be better to regard the patch as an
experiment only, which should go no further.
I think the bug should stay open, though. CC Mode still doesn't handle
multi-line comments absolutely correctly, and these could surely be
fixed, like Stefan said, by using syntax-table text properties somehow.
I also created a plethora of syntax test cases for the patch, some of
which are applicable to syntax.c as is. I'll get around to sorting
these out and committing them sometime.
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2021-05-13 14:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 9:35 bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped Alan Mackenzie
2020-09-22 14:09 ` Stefan Monnier
2020-09-22 19:41 ` Alan Mackenzie
[not found] ` <handler.43558.B.160076736116422.ack@debbugs.gnu.org>
2020-09-23 8:57 ` Alan Mackenzie
2020-09-23 9:01 ` Mattias Engdegård
2020-09-23 14:48 ` Alan Mackenzie
2020-09-23 18:44 ` Stefan Monnier
2020-09-23 19:44 ` Alan Mackenzie
2020-09-23 20:02 ` Stefan Monnier
2020-09-24 10:20 ` Alan Mackenzie
2020-09-24 16:56 ` Stefan Monnier
2020-09-24 18:50 ` Alan Mackenzie
2020-09-24 22:43 ` Stefan Monnier
2020-11-19 21:18 ` Alan Mackenzie
2020-11-19 22:47 ` Stefan Monnier
2020-11-22 13:12 ` Alan Mackenzie
2020-11-22 15:20 ` Stefan Monnier
2020-11-22 17:08 ` Alan Mackenzie
2020-11-22 17:46 ` Dmitry Gutov
2020-11-22 18:19 ` Alan Mackenzie
2020-11-22 20:39 ` Dmitry Gutov
2020-11-22 21:13 ` Alan Mackenzie
2020-11-22 21:34 ` Dmitry Gutov
2020-11-22 22:01 ` Alan Mackenzie
2020-11-22 23:00 ` Stefan Monnier
2021-05-13 10:38 ` Lars Ingebrigtsen
2021-05-13 14:51 ` Alan Mackenzie [this message]
2021-05-16 13:53 ` Lars Ingebrigtsen
2022-04-28 11:17 ` Lars Ingebrigtsen
2022-04-28 18:52 ` Alan Mackenzie
2020-11-22 23:10 ` Stefan Monnier
2020-11-22 15:35 ` Eli Zaretskii
2020-11-22 17:03 ` Alan Mackenzie
2020-09-24 18:52 ` Michael Welsh Duggan
2020-09-24 19:57 ` Alan Mackenzie
2020-09-24 20:27 ` Michael Welsh Duggan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJ085r9abcNUsbSd@ACM \
--to=acm@muc.de \
--cc=43558@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).