From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#45198: 28.0.50; Sandbox mode Date: Sat, 17 Apr 2021 20:57:57 +0100 Message-ID: References: <5818DFAA-3A9C-4335-BAAF-1227A02C290A@acm.org> <19511709-E42B-4ABD-9823-39EA08A79B1F@gmail.com> <83v98kvr7y.fsf@gnu.org> <9A5BCDF3-6543-46C0-AB56-2311392FC549@gmail.com> <78F41D0B-D2F6-444C-9B5C-9C50CFF2CFBD@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29644"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 45198@debbugs.gnu.org, stefan@marxist.se, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Stefan Monnier To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 17 21:59:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXr6c-0007be-8P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 21:59:50 +0200 Original-Received: from localhost ([::1]:59662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXr6b-0002gg-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 15:59:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXr62-0002fs-N5 for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 15:59:14 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33166) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXr5q-0001II-2p for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 15:59:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXr5q-0001Y0-1u for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 15:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45198-submit@debbugs.gnu.org id=B45198.16186894935887 (code B ref 45198); Sat, 17 Apr 2021 19:59:02 +0000 Original-Received: (at 45198) by debbugs.gnu.org; 17 Apr 2021 19:58:13 +0000 Original-Received: from localhost ([127.0.0.1]:44712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXr53-0001Wt-AF for submit@debbugs.gnu.org; Sat, 17 Apr 2021 15:58:13 -0400 Original-Received: from outbound.soverin.net ([116.202.65.218]:54177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXr51-0001Wd-8b for 45198@debbugs.gnu.org; Sat, 17 Apr 2021 15:58:12 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 6076F601B8; Sat, 17 Apr 2021 19:58:03 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1618689481; bh=0mIiFn2oP9ISihYPjw8gvV3w48yPKz6mYVpyGZ6eVE8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RvXLmMEVWXgfFQK9R530MXHg3LNDTYVW4k8mmNB7V6cMfB5ppzQQMdMXgad08xs75 dVZX3NiIImDcg8ik0V7GjlAlue27N/2zbWsnHMY3DyEg55VXvs7dx5+xSi5VUpSnH+ d1UEzayHlDUX9pZKLlqoq7PSPmEhjuhlflmIYYaHlkD+omBRFgEj9Paq7NIiMFLmes 5//AfFMO9ZfvVz20i4gerge5UNwD65Iymo2UnlqZGkvz7KM23PsSRMe4IcrLAmRAOs pu0XYX16gWjRiTjh3lplaLBDAvz8IAXxqktRNl375IPzIou5zCl0lAlR5sp85zXEV2 UJwM5Mm+ezzsQ== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 72474202BD1872; Sat, 17 Apr 2021 20:57:57 +0100 (BST) Mail-Followup-To: Alan Third , Philipp , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier , Eli Zaretskii , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 45198@debbugs.gnu.org, stefan@marxist.se Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204264 Archived-At: On Sat, Apr 17, 2021 at 09:42:31PM +0200, Philipp wrote: > > diff --git a/lisp/subr.el b/lisp/subr.el > > index c2be26a15f..196512c0c6 100644 > > --- a/lisp/subr.el > > +++ b/lisp/subr.el > > Should this maybe be in a platform-specific file such as ns-fns.el (like dos-fns.el, w32-fns.el)? > > @@ -6262,4 +6262,22 @@ internal--format-docstring-line > > This is intended for internal use only." > > (internal--fill-string-single-line (apply #'format string objects))) > > > > +(when (eq system-type 'darwin) > > + (defun darwin-sandbox-enter (dirs) > > I don't think we use the "darwin-" prefix anywhere else in Emacs. > Maybe use a "ns-" prefix. Also I think such internal functions > commonly have an "internal" piece somewhere in their name, e.g. > "ns-enter-sandbox-internal". I'm coming to this late, so I may be misunderstanding what this is, but as far as I can tell it has nothing to do with Cocoa or GNUstep, so I would suggest not using the ns- prefix. If you're running, say, terminal Emacs on a Darwin system, ns-fns.el is not called. NS =/= Darwin. -- Alan Third