From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#47781: 28.0.50; (window-list-1 nil t) returns nil when minibuffer is inactive Date: Fri, 16 Apr 2021 17:48:56 +0000 Message-ID: References: <87czuw9zk9.fsf@host.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="318"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47781@debbugs.gnu.org, Gregory Heytings , acm@muc.de To: marmot-te Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 16 20:18:47 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXT3H-000AXx-A1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 20:18:47 +0200 Original-Received: from localhost ([::1]:34480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXT3G-0003jL-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 14:18:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXSbS-0000cY-Sg for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 13:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXSbS-0005TX-IT for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 13:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXSbS-0003tv-F1 for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 13:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Apr 2021 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47781 X-GNU-PR-Package: emacs Original-Received: via spool by 47781-submit@debbugs.gnu.org id=B47781.161859534614901 (code B ref 47781); Fri, 16 Apr 2021 17:50:02 +0000 Original-Received: (at 47781) by debbugs.gnu.org; 16 Apr 2021 17:49:06 +0000 Original-Received: from localhost ([127.0.0.1]:41599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXSaY-0003sG-Cg for submit@debbugs.gnu.org; Fri, 16 Apr 2021 13:49:06 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:57173 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lXSaV-0003rh-TY for 47781@debbugs.gnu.org; Fri, 16 Apr 2021 13:49:05 -0400 Original-Received: (qmail 13311 invoked by uid 3782); 16 Apr 2021 17:48:56 -0000 Original-Received: from acm.muc.de (p4fe15aa2.dip0.t-ipconnect.de [79.225.90.162]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 16 Apr 2021 19:48:56 +0200 Original-Received: (qmail 32750 invoked by uid 1000); 16 Apr 2021 17:48:56 -0000 Content-Disposition: inline In-Reply-To: <87czuw9zk9.fsf@host.localdomain> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204156 Archived-At: Hello, Marmot-Te. On Thu, Apr 15, 2021 at 00:11:34 +0000, marmot-te wrote: > Hi, > I read from the docstring of the function > > MINIBUF t means consider the minibuffer window even if the > > minibuffer is not active > However, > with emacs -Q > and the minibuffer inactive > (window-list-1 nil t) > ;; => nil > I think this is related to this build since I cannot reproduce > with emacs 26.1 (in this case it returns the list of windows, > minibuffer included, as expected). > In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.5, cairo version 1.16.0) > of 2021-02-09 built on debian-10-gccemacs > Repository revision: 1f626e9662d8120acd5a937f847123cc2b8c6e31 > Repository branch: native-comp > Windowing system distributor 'The X.Org Foundation', version > 11.0.12004000 > System Description: Debian GNU/Linux 10 (buster) [ .... ] I think the following patch, to .../src/window.c, fixes it: diff --git a/src/window.c b/src/window.c index caf9df6c13..23eb802950 100644 --- a/src/window.c +++ b/src/window.c @@ -2633,7 +2633,8 @@ candidate_window_p (Lisp_Object window, Lisp_Object owindow, candidate_p = ((EQ (XWINDOW (all_frames)->frame, w->frame) || (EQ (f->minibuffer_window, all_frames) && EQ (XWINDOW (all_frames)->frame, FRAME_FOCUS_FRAME (f)))) - && !is_minibuffer (0, XWINDOW (all_frames)->contents)); + && (EQ (minibuf, Qt) + || !is_minibuffer (0, XWINDOW (all_frames)->contents))); else if (FRAMEP (all_frames)) candidate_p = EQ (all_frames, w->frame); .. Please feel free to try it out, and let us know how well it works. Thanks! > -- > <:3nn~~ > <:3nn~~ > <:3nn~~ -- Alan Mackenzie (Nuremberg, Germany).