From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#47150: [External] : bug#47150: 28.0.50; Incorrect major-mode in minibuffer Date: Tue, 20 Apr 2021 10:25:25 +0000 Message-ID: References: <887bda9c-906c-4163-a8db-08b45e021bfd@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15547"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47150-done@debbugs.gnu.org, acm@muc.de, Stefan Monnier To: Sheng Yang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 20 12:28:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYnco-0003wb-Hx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Apr 2021 12:28:58 +0200 Original-Received: from localhost ([::1]:49882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYncn-0000aZ-GT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Apr 2021 06:28:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYna1-0006J3-2U for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 06:26:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYnZy-00063K-7i for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 06:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYnZy-0006vH-4l for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2021 06:26:02 -0400 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Apr 2021 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47150 X-GNU-PR-Package: emacs Mail-Followup-To: 47150@debbugs.gnu.org, acm@muc.de, styang@fastmail.com Original-Received: via spool by 47150-done@debbugs.gnu.org id=D47150.161891433626568 (code D ref 47150); Tue, 20 Apr 2021 10:26:01 +0000 Original-Received: (at 47150-done) by debbugs.gnu.org; 20 Apr 2021 10:25:36 +0000 Original-Received: from localhost ([127.0.0.1]:53039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYnZX-0006uQ-O0 for submit@debbugs.gnu.org; Tue, 20 Apr 2021 06:25:36 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:19675 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lYnZV-0006uA-E1 for 47150-done@debbugs.gnu.org; Tue, 20 Apr 2021 06:25:34 -0400 Original-Received: (qmail 38779 invoked by uid 3782); 20 Apr 2021 10:25:26 -0000 Original-Received: from acm.muc.de (p4fe15986.dip0.t-ipconnect.de [79.225.89.134]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 20 Apr 2021 12:25:26 +0200 Original-Received: (qmail 14815 invoked by uid 1000); 20 Apr 2021 10:25:25 -0000 Content-Disposition: inline In-Reply-To: <887bda9c-906c-4163-a8db-08b45e021bfd@www.fastmail.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204527 Archived-At: Hello, Sheng. On Mon, Apr 19, 2021 at 14:18:29 -0500, Sheng Yang wrote: > Hi everyone, > Thanks you all for the discussion and especially @Stefan for the patch. > The patch looks good to me (I am on emacs 28 pgtk branch). Many thanks for the testing! > It does cause lispy and telega to malfunction due to their use of > minibuffer-inactive-mode, but I managed to fix those by replacing (eq > major-mode 'minibuffer-inactive-mode) with (derived-mode-p > 'minibuffer-mode). Yes. It seems this is unavoidable. > When this patch gets merged to master, I will send PRs to all the > packages I am aware of using minibuffer-inactive-mode, i.e. > lispy/telega/smartparens/lunarymacs (and possibly package-lint). Thanks for doing that. I've now committed the patch (modified in line with Stefan's suggestions) to the master branch at savannah, and I'm closing the bug with this post. > Best regards, > Sheng [ .... ] > Sheng Yang(杨圣), PhD > Computer Science Department > University of Maryland, College Park > E-mail: styang@fastmail.com > E-mail (old but still used): yangsheng6810@gmail.com -- Alan Mackenzie (Nuremberg, Germany).