From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets Date: Sun, 4 Apr 2021 14:14:48 +0100 Message-ID: References: <83im5tfr6t.fsf@gnu.org> <83sg4vepym.fsf@gnu.org> <83k0piedxi.fsf@gnu.org> <83zgyecnfx.fsf@gnu.org> <83tuomclte.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="JK6iBu/kG6jJDNx5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1931"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, 47074@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 04 15:15:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT2bW-0000LB-Bd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 15:15:50 +0200 Original-Received: from localhost ([::1]:60164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT2bU-0001r4-Gv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 09:15:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT2al-0001p8-V1 for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 09:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lT2ak-00071Y-LN for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 09:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lT2ak-0001il-EI for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 09:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Apr 2021 13:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47074 X-GNU-PR-Package: emacs Original-Received: via spool by 47074-submit@debbugs.gnu.org id=B47074.16175421016594 (code B ref 47074); Sun, 04 Apr 2021 13:15:02 +0000 Original-Received: (at 47074) by debbugs.gnu.org; 4 Apr 2021 13:15:01 +0000 Original-Received: from localhost ([127.0.0.1]:35085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT2aj-0001iI-1b for submit@debbugs.gnu.org; Sun, 04 Apr 2021 09:15:01 -0400 Original-Received: from outbound.soverin.net ([116.202.65.218]:46587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT2ag-0001i4-M1 for 47074@debbugs.gnu.org; Sun, 04 Apr 2021 09:15:00 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 028EF600CB; Sun, 4 Apr 2021 13:14:53 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1617542092; bh=bcmVoM/xgbZ7wPWf9ZTE1vTPDaTrrH4lUytSaWjTMug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZrTPMbNv+gyo/9QwQOIplEXV7gU9m3AeFKaBvmYAJXUUGTU70bLnPQDeH9D2dq0AD HEHGxMDs6MvMMFeUuY/+AUVixnTquKDZh+u+KA6n97lfixQLEwLVa9P4JA8Crin46z qaVhENeSR6R2dIZ9vk4nbJ9/SDQMIHMuuvXKnMEBmAq3sXF4V0/iTtQKDHnVit4jBC TIBCDP5uAQo3XDAwsDxR99/1fMYiTL3Vabwnj9Px9q3yy5Htr/2Aj0xa6MlXOgh049 IVMNQsgcngacsOctShYCGh20RMKe7J0crN51fXXr5F7aE9GKqF6Sy4jOtY9intuapP QeyB7IlVRoq8A== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 853F4202B85E41; Sun, 4 Apr 2021 14:14:48 +0100 (BST) Mail-Followup-To: Alan Third , Eli Zaretskii , stefan@marxist.se, 47074@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <83tuomclte.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203541 Archived-At: --JK6iBu/kG6jJDNx5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Apr 04, 2021 at 02:48:29PM +0300, Eli Zaretskii wrote: > > Date: Sun, 4 Apr 2021 12:37:58 +0100 > > From: Alan Third > > Cc: Stefan Kangas , 47074@debbugs.gnu.org > > > > > Thanks. The results on my system are much worse than the XPM images, > > > see the two attached screenshots. > > > > Something is going wrong with the rendering of the SVGs. It looks as > > though the background is offset, and the background and foreground > > colours are backwards. > > > > What version of librsvg do you have? > > 2.40.1. I can see something similar, but not exactly the same, on one of my build virtual machines running 2.40.5. That particular problem looks like an rsvg bug, since rsvg-view-3 displays it the same way. It appears to be this (and one other related problem): https://github.com/svg/svgo/issues/822 I've reformatted the svg files so they display correctly here, but can you please check that the attached patch fixes the problem for you as well? -- Alan Third --JK6iBu/kG6jJDNx5 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Work-around-librsvg-bug-bug-47074.patch" >From 756306531f394d4160f6506042984f4583351258 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sun, 4 Apr 2021 14:08:48 +0100 Subject: [PATCH] Work around librsvg bug (bug#47074) Librsvg <= 2.40 has restrictions on how certain numbers can be run together in path elements which do not match the SVG spec. * etc/images/checkbox-mixed.svg: * etc/images/checked.svg: * etc/images/radio-checked.svg: * etc/images/unchecked.svg: Separate problem numbers. * etc/images/radio-mixed.svg: Separate problem numbers and color and font-weight data. --- etc/images/checkbox-mixed.svg | 4 ++-- etc/images/checked.svg | 2 +- etc/images/radio-checked.svg | 4 ++-- etc/images/radio-mixed.svg | 4 ++-- etc/images/unchecked.svg | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/etc/images/checkbox-mixed.svg b/etc/images/checkbox-mixed.svg index 647a0ccf9b..6e46b803c8 100644 --- a/etc/images/checkbox-mixed.svg +++ b/etc/images/checkbox-mixed.svg @@ -1,6 +1,6 @@ - - + + diff --git a/etc/images/checked.svg b/etc/images/checked.svg index b84dde1c3a..4cbdef04f2 100644 --- a/etc/images/checked.svg +++ b/etc/images/checked.svg @@ -1,6 +1,6 @@ - + diff --git a/etc/images/radio-checked.svg b/etc/images/radio-checked.svg index 5354324c34..8950b447a0 100644 --- a/etc/images/radio-checked.svg +++ b/etc/images/radio-checked.svg @@ -1,6 +1,6 @@ - - + + diff --git a/etc/images/radio-mixed.svg b/etc/images/radio-mixed.svg index e2a6fcae57..1b3bfa78e9 100644 --- a/etc/images/radio-mixed.svg +++ b/etc/images/radio-mixed.svg @@ -1,6 +1,6 @@ - + - + diff --git a/etc/images/unchecked.svg b/etc/images/unchecked.svg index 7cc1516220..09bab8de95 100644 --- a/etc/images/unchecked.svg +++ b/etc/images/unchecked.svg @@ -1,3 +1,3 @@ - + -- 2.29.2 --JK6iBu/kG6jJDNx5--